•  

Comment Results

Review Name Created Custom Fields Content
TD-LEAH-32-4 04 Sep 2024

Can some of these functions be added to the leahi-fwcommon alarm management? Like active alarm or clear alarm. I understand that it might be too difficult to tailor these functions for all of the stacks.

DD-LEAH-210-5 29 Aug 2024

Move down to app includes section and replace <> with "".

DD-LEAH-210-5 29 Aug 2024

Let's be consistent about to do comments so they are easily searched for. We've been using // TODO blah blah blah...

Are these to dos going to be addressed now or later?

DD-LEAH-210-5 30 Aug 2024

No fill mode.

TD-LEAH-32-4 04 Sep 2024

But what is 0x3000?

DG-DEN-17053-6 16 Sep 2024

Done

DD-LEAH-220-2 17 Sep 2024

Done.

DD-LEAH-220-2 16 Sep 2024

Should publish timer counter be initialized here?

DD-LEAH-220-2 16 Sep 2024

Should each conductivity sensor have its own state? It doesn't look like the state can be shared by all sensors.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Should we reset state to something valid? Or s/w reset? Try to recover in some way?

BOOTLOADER-LEAH-1415-1 01 Oct 2024

When are we doing this?

BOOTLOADER-LEAH-1415-1 01 Oct 2024

When do you plan to do this?

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Should only be one blank line at end of file. Should also be an end group marker down here.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 30 Sep 2024

Change to "ID of concentrate pump to ramp."

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

please rename to:
acidConcentratePotassium
acidConcentrateCalcium

TD-LEAH-32-4 28 Aug 2024

Fixed.

HD-DEN-15196-2 14 May 2023

This is a 4th level state. Currently not supported I think.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

No watchdog manager?

HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15196-2 14 May 2023

Remove extra "}". Should be 2 blank lines above test support banner.

DD-LEAH-210-5 29 Aug 2024

Done.

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15196-2 14 May 2023

Remove blank line.

DG-DEN-15274-1 17 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-318-1 27 May 2025

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LDT-261-1 27 May 2025

Do we have an enum for this message defined?

DD-LEAH-210-5 27 Aug 2024

Add blank line between file header and first include.

DD-LEAH-210-5 29 Aug 2024

Done.

DD-LEAH-210-5 29 Aug 2024

Done.

TD-LDT-802-1 28 Jul 2025

I added the door require function.

TD-LDT-802-1 27 Jul 2025

Do we need to require door closed in the 2 states where blood pump is running (blood recirculating)? And do we need to allow door open in the other state where only dialysate recircs (no BP running so ok to open door)?

Seems like better place for all of this is in transitionToTxPausedState().

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

TD-LEAH-32-4 04 Sep 2024

Per the design we agreed on TD not checking with RO directly, right?

DD-LEAH-210-5 29 Aug 2024

I've been trying to replace all references to a "module" with "unit".

DD-LEAH-210-5 29 Aug 2024

Add details for alarm.

DD-LEAH-210-5 29 Aug 2024

Add _ between fpga and dd.

DD-LEAH-210-5 29 Aug 2024

Remove * at end of line.

DD-LEAH-210-5 29 Aug 2024

Move up to Halcogen include grouping. All of them.

DD-LEAH-210-5 30 Aug 2024

Rename to Messaging so it gets added to that s/w unit.

DD-LEAH-210-5 30 Aug 2024

No recirculate mode.

DD-LEAH-210-5 30 Aug 2024

No drain mode.

DD-LEAH-210-5 30 Aug 2024

This is a group end thing and I don't see a group above that it goes with.

DD-LEAH-210-5 29 Aug 2024

Restore extra blank line.

HD-DEN-17053-1 13 Sep 2024

Done

TD-LEAH-41-1 16 Sep 2024

Fixed.