•  

Comment Results

Review Name Created Custom Fields Content
DD-LEAH-210-5 29 Aug 2024

I see these are grouped as set or get.
Consider grouping all get and sets together by h/w component.

DD-LEAH-220-2 16 Sep 2024

Yes, Currently HDD listing this pressure sensor. Once HDD cleanup is done, we may remove/comment the source as required.

DD-LEAH-220-2 17 Sep 2024

Done.

DD-LEAH-220-2 17 Sep 2024

Done.

DD-LEAH-220-2 16 Sep 2024

Who will be calling this function? Is there any chance this function can be called more than once in a single task iteration? Is it possible to request a write at one address and then immediately request another write at another address? If so, I think the second write request will overwrite the first - you would need to add a write request queue that the write state machine could handle one job at a time.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

I don't think retries are needed here. We should message UI to inform on the problem though.

DD-LEAH-227-1 30 Sep 2024

Should hasTgtBeenReached be set to TRUE here?

DD-LEAH-227-1 01 Oct 2024

Done.

DD-LEAH-227-1 30 Sep 2024

Change to "... pump turned on."

DD-LEAH-227-1 30 Sep 2024

It's actually the temperature sensors state, not the sensor that may be invalid.

TD-LEAH-32-4 28 Aug 2024

Clarified.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Thanks
RESOLVED.

HD-DEN-15196-2 15 May 2023

Fixed. Thanks!

DD-LEAH-210-5 29 Aug 2024

Will work on it as we get more clarity on Operation modes.

HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15196-2 14 May 2023

Missing function header.

DD-LEAH-210-5 27 Aug 2024

Outputs are the 3 bit states variables right now - but consider making those variables local to caller and passed in as reference params.

HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DENBUG-318-1 22 May 2025

Done

HD-DEN-15229-1 15 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15274-1 14 May 2023

Consider moving this declarations to top of function and then removing the outer {} for these cases.

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15196-2 16 May 2023

My mistake. fixed!

LEAHI-DIALIN-LDT-566-1 22 May 2025

I believe pre-gen command has something like 4 parameters. Msg ID name should change (talk w/ Vinay). Not requesting data. It's a start/stop command.

DD-LEAH-210-5 30 Aug 2024

Done.

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

added

LEAHI-DIALIN-LDT-261-1 27 May 2025

Fixed!

DD-LEAH-210-5 30 Aug 2024

I guess, this file will be deleted, and common source will be used.

DD-LEAH-210-5 30 Aug 2024

Done.

UI-DEN-17055-1 18 Sep 2024

please use the settings configuration formatting when needed in the following function:

void View::VHDUsageInfo::onActionReceive(const HDUsageInfoResponseData &vData)


*if there are other places as we talked please update them with that as well.*
*please define the QSTring variable on top of the function and then used that variable (aka move your private variable in the function scope)*

_serviceDateFormat = _Settings.dateFormat();


and remove the private variable:

    const QString _LastTreatmentDateFormat    = "yyyy/MM/dd";
BOOTLOADER-LEAH-1415-1 04 Sep 2024

Do we need this header?

HD-DEN-15306-1 22 May 2023

Added alarm 62 detection disable as suggested.

LEAHI-SW-LDT-261-2 28 May 2025

Please briefly explain what is going to be done in the same line.
E.g., not implemented in FW, subject to change.

TD-LEAH-32-4 04 Sep 2024

Why? I don't recall commenting on private function prototypes. We comment them in function headers.

LEAHI-APPLICATION-LDT-1516-1 25 Jul 2025

removed and updated to create the all the menu models inside of MainMenu.qml and set the models when needed

HD-DEN-15306-1 24 May 2023

The valves are not returned to their target position until the alarm is cleared. I could make a broader change, but is that what you're suggesting?

TD-LEAH-32-4 27 Aug 2024

I guess we need to rename as DD fault. Also, can we introduce RO fault parameter? This would help us to differentiate RO alarms when plugged into DD.

TD-LEAH-32-4 04 Sep 2024

We should have #define for this number.

DG-DEN-17053-6 13 Sep 2024

No colon.

TD-LDT-802-1 27 Jul 2025

Add a comment that we are consuming and ignoring stop button press events here.

TD-LEAH-41-1 16 Sep 2024

Fixed.

TD-LDT-802-1 27 Jul 2025

Why de-energized state?

DD-LEAH-220-2 17 Sep 2024

Done.

DD-LEAH-220-2 17 Sep 2024

Done.

DD-LEAH-220-2 16 Sep 2024

I don't see a need for packing. All F32s.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Don't call get function in a switch. Is get function getting a state or a command? Seems like a command, so why is "State" in the function name?

DD-LEAH-227-1 30 Sep 2024

Shouldn't the "hasTurnOnPumpsBeenRequested" flag be set to FALSE in here somewhere?

DD-LDT-1473-1 28 Jul 2025

With the updated FPGA logic for continuous flow rate, doesn't need this variable anymore.

DD-LEAH-227-1 01 Oct 2024

Done.

TD-LDT-802-1 28 Jul 2025

I made the state as non-terminal.