•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-1730-1 24 Jul 2025

Thank you Stephen Quong
That is a great catch.
After your comment, I dug a little deeper.
These two properties are actually defined as global properties/variables in this view and will get updated/adjusted by FW with other messages.
Although we do not use them for now, as they will change in pre-treatment and with the "Ultrafiltration Edit", we should keep them for later use.

Nicholas Ramirez
Please revert all changes to the minimum and maximum values.

I will also same comment in the following bug to address the System Engineers' bug report.
https://diality.atlassian.net/browse/LDT-1730?focusedCommentId=75775

LEAHI-APPLICATION-LDT-1516-1 28 Jul 2025

resolved.

LEAHI-APPLICATION-LDT-1516-1 24 Jul 2025

look into how many pages need to add topMargin instead of anchoring headerbar

TD-LDT-736-1 28 Jul 2025

Add alarm.

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

DG-DEN-14902-1 15 May 2023

Introducing build flags seems like a bad idea. Are these temporary tests?

TD-LEAH-32-4 28 Aug 2024

Added dummy fields to match addressing specified in HDD.

DIALIN-DEN-15196-1 16 May 2023

I'll defer to John he is the one implementing the test code changes.

LEAHI-DIALIN-LDT-566-1 23 May 2025

Remove "NUM_OF..." enum from header.

DD-LEAH-210-5 29 Aug 2024

Done.

DD-LEAH-210-5 29 Aug 2024

Done.

DG-DEN-15274-1 14 May 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15336-1 14 May 2023

Remove blank line.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Why is this interrupt protected?

DG-DEN-15336-1 15 May 2023

RESOLVED in CODE WALKTHROUGH.

BOOTLOADER-LEAH-1415-1 01 Oct 2024

Don't call get function in a switch.

DG-DEN-15336-1 15 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15196-2 15 May 2023

going to keep the old style of events for now so we dont break previous V&V testing.

HD-DEN-15196-2 15 May 2023

Fixed. Thanks!

HD-DEN-15196-2 15 May 2023

unneeded code from other event usage. Fixed. Thanks!

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15196-2 15 May 2023

Fixed. Thanks!

HD-DEN-15196-2 14 May 2023

In consumable self-test, you removed the old send substate change event. Why keep this one?

HD-DEN-15196-2 14 May 2023

Is there any submode of treatment mode that does not have substates?

HD-DEN-15196-2 14 May 2023

What is d2?

HD-DEN-15274-1 15 May 2023

Done

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15229-1 16 May 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15274-1 16 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15274-1 16 May 2023

function wants a U32. C will convert automatically, so not necessary I guess.

DD-LEAH-210-5 30 Aug 2024

Done.

HD-DEN-15196-2 16 May 2023

My mistake. fixed!

DD-LEAH-210-5 30 Aug 2024

Done.

HD-DEN-15196-2 16 May 2023

converted all calls to setCurrentSubState to have a casted U32. Thanks!

HD-DEN-15196-2 16 May 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-210-5 30 Aug 2024

Done.

HD-DEN-15196-2 16 May 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-15196-3 16 May 2023

Does Dialin need to capture response too or just proxy the request?

DD-LEAH-210-5 30 Aug 2024

Done.

DIALIN-DEN-15196-1 16 May 2023

Correct

DG-DEN-15274-1 16 May 2023

Done

DD-LEAH-210-5 30 Aug 2024

Done.

DG-DEN-14902-1 16 May 2023

Includes should be in alphabetical order.

TD-LEAH-32-4 30 Aug 2024

Need to add DD and RO.

DG-DEN-17053-6 16 Sep 2024

Done

HD-DEN-15306-1 23 May 2023

So then can we remove power loss alarm active checks from this condition (just keep the cpld power loss check as before)?