Comment Search

Done.

Done.

Done.

Change to "TRUE if a park request is pending for the given concentrate pump, FALSE if not."

Can target speed be negative (for reverse)? If so, why are we not doing a fabs() above (about 8 lines up)? If not, why are we doing fabs() here?

RESOLVED in CODE WALKTHROUGH.

'val' and 'max' are being set differently than the previous version.

I think that's right. Waiting for schematic to see how it will work with Leahi.

Add a blank line to separate code with different commenting styles - Doxygen gets confused if you don't.

yes we should. fixed to have these calls in their respective transition functions.

Done.

removed and updated to create the all the menu models inside of MainMenu.qml and set the models when needed

I thought we were going to leave BLD state out for now?

Do we need to call this function on transition to consumables self-test so that op modes will get initial state? (Question applies throughout this code branch)

RESOLVED IN CODE WALKTHROUGH

Do we need the alarm active checks? Isn't power loss check sufficient?

Done.

Stephen Quong
I belive it is still effective,
Isn't it Nicholas Ramirez ?

For messages sent, I've been doing details \b Message \b Sent: ...

fixed. thanks!

fixed in renamed file. thanks.

Add a blank line between THd control setting and other valve settings because the comment above only applies to the THd assignment. The other valve assignments should get their own comment.

Indent looks weird here. Maybe just say "time windowed error count for FPGA clock speed alarm" for readability.

If you include SystemCommDD, you shouldn't have to include lower level SystemComm header.

Add one for RO too.