•  

Comment Results

Review Name Created Custom Fields Content
DD-LEAH-210-5 29 Aug 2024

Done.

DD-LEAH-210-5 29 Aug 2024

Done.

TD-LEAH-41-1 16 Sep 2024

85

LEAHI-DIALIN-LDT-566-1 22 May 2025

There is an additional 'UF pump' added in the concentrate pump driver. Please add the dialin support for the same,

DD-LEAH-210-5 29 Aug 2024

Done.

LEAHI-APPLICATION-LDT-1730-1 24 Jul 2025

RESOLVED

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

BOOTLOADER-LEAH-1415-1 04 Sep 2024

close the above header

TD-LEAH-32-4 04 Sep 2024

This one masks off lowest nibble. I will make a #define for it.

TD-LEAH-32-4 04 Sep 2024

Details are in the header file where the group is defined. This is just saying that all of the code below goes into this group.

TD-LEAH-32-4 04 Sep 2024

I kept these out of common because it's doing some specific things like broadcasting alarm trigger message.

DD-LEAH-210-5 29 Aug 2024

Remove blank line.

DD-LEAH-210-5 29 Aug 2024

Remove this comment. Redundant.

DD-LEAH-210-5 29 Aug 2024

Move down to app includes grouping.

DD-LEAH-210-5 29 Aug 2024

Move down to normal app includes group and replace <> with "".

TD-LEAH-41-1 16 Sep 2024

Noe has not updated TD HDD so I can't update my side yet.

DD-LEAH-220-2 16 Sep 2024

Use "publishes" instead of "advertises".

UI-DEN-17055-1 23 Sep 2024

Updated the code to not show any decimals.

UI-DEN-17055-1 23 Sep 2024

RESOLVED

UI-DEN-17055-1 22 Sep 2024

Displaying hours as a float can be confusing and not user-friendly.
For example, seeing "11.7" requires users to calculate the actual hours and minutes, which adds unnecessary complexity.
Please consult with the system team to explore a more intuitive format for representing time, such as separating hours and minutes (e.g., "11h 42m" or 11:42) for better clarity.

TD-LEAH-47-1 25 Sep 2024

Needs to be updated per latest testsupport routine?

TD-LEAH-47-1 26 Sep 2024

I thought about that but decided to keep the common functions simple by calling the param a maximum.

TD-LEAH-47-1 26 Sep 2024

This one is different. Not using standard override payload as it is not an override - it's a set command.

TD-LEAH-47-1 26 Sep 2024

Fixed.

TD-LEAH-47-1 26 Sep 2024

No. Button press/release events will be sent as asynchronous events.

TD-LEAH-47-1 26 Sep 2024

Removed.

TD-LEAH-47-1 25 Sep 2024

I guess this code is common for all stacks. can we remove TD reference across the functions?

TD-LEAH-47-1 25 Sep 2024

can we modify the routine to take index, max variables as it is ( without subtracting -1) and adjust the conditions inside the routine ( by removing = in the <= )?

DD-LEAH-227-1 30 Sep 2024

Change to concentratePumps[] or isConcPumpParkInProgress.

DD-LEAH-227-1 30 Sep 2024

Should be "hasTurnOnPumpsBeenRequested". Also, "hasParkBeenRequested" and "pumpTargetSpeed".

DD-LEAH-227-1 30 Sep 2024

Change to "... the target flow rate for a given concentrate pump."

DD-LEAH-227-1 30 Sep 2024

Change to "... current target speed for the given concentrate pump."

DD-LEAH-227-1 30 Sep 2024

Change to "... current measured flow rate (in mL/min) for the given concentrate pump."

DD-LEAH-227-1 30 Sep 2024

Remove blank line.

DD-LEAH-227-1 30 Sep 2024

... if we are parked.

DD-LEAH-227-1 30 Sep 2024

Use CONCENTRATEPUMPS_FIRST.

DD-LEAH-227-1 30 Sep 2024

Also setting pump direction.

DD-LEAH-227-1 30 Sep 2024

Change to "... turns on a given concentrate pump ...".

HD-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

RESOLVED.

TD-LEAH-32-4 28 Aug 2024

Fixed.

HD-DEN-15196-2 15 May 2023

I want to keep the old sub state change events for dialin compatibility. I believe other tests use the sub state change event