•  

Comment Results

Review Name Created Custom Fields Content
DD-LEAH-220-2 17 Sep 2024

Done.

LEAHI-DIALIN-LDT-566-1 22 May 2025

should be "post gen"

DD-LEAH-220-2 17 Sep 2024

Done.

DD-LEAH-220-2 16 Sep 2024

Switch order of first 2 enums so Hydraulics Outlet is first.

DD-LEAH-220-2 16 Sep 2024

Structures should be up in the definitions section - not in the private data section.

DD-LEAH-220-2 16 Sep 2024

Add a blank line before test functions.

LEAHI-DIALIN-LDT-566-1 23 May 2025

Missing function description in header.

UI-DEN-17055-1 19 Sep 2024

RESOLVED

LEAHI-DIALIN-LDT-566-1 22 May 2025

There is one more dialin command needs to be supported (MSG_ID_DD_GEND_EXEC_STATE_OVERRIDE_REQUEST). This command is used to change the state of Gen dialysate execution ( to help system team to move/jump into desired state by not executing in order fashion)

RO-LDT-566-1 21 May 2025

Remove extra blank line.

LEAHI-APPLICATION-LDT-1730-1 24 Jul 2025

'minimum' is also referenced in:
SDDs/Main_Treatment/FinalDiagram.dot

DD-LDT-1473-1 27 Jul 2025

Isn't there a common override function that does this?

DD-LDT-1473-1 28 Jul 2025

Done.

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

Generally, any anchoring/positioning properties for the top level item should be set in the parent object where this object is being instantiated since any changes to these properties in the parent will be overridden here and it may not be obvious that it is happening.

TD-LDT-736-1 28 Jul 2025

Came from Denali, so I believe this is what they wanted. The nearly 5 minutes is the one the user sees.

LEAHI-APPLICATION-LDT-1516-1 28 Jul 2025

resolved.

TD-LDT-802-1 28 Jul 2025

Move this above switch statement.

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

i removed the comment to be more clear

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

RESOLVED

TD-LDT-736-1 29 Jul 2025

Fixed.

TD-LDT-736-1 28 Jul 2025

Is it just on/off control or variable speed control?

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed in renamed file. thanks!

RO-LDT-566-2 30 Jul 2025

when the FP receives MSG_ID_DD_FP_START_STOP_CMD_REQUEST, it'll set the variable within getPreGenRequest to be true.

RO-LDT-566-2 30 Jul 2025

Fixed. Thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. Thanks!

HD-DEN-15104-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-210-5 29 Aug 2024

Fixed

HD-DEN-15104-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15229-1 12 May 2023

Should we have an else to turn pump and heater back on when door is closed?

HD-DEN-15229-1 12 May 2023

Since pump is going to be on and next state is not calling your door check function, should we call doorClosedRequired( TRUE, TRUE ) here? Or next state could call your door check function to handle it.

DD-LEAH-210-5 29 Aug 2024

Done. Created GPIO.C which contains only watchdog signals for now. can be expanded based on the design.

HD-DEN-15104-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1 12 May 2023

Don't we have an enum for these values?

HD-DEN-15104-1 12 May 2023

Do we need to check for these in out exec?

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15104-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-210-5 30 Aug 2024

Done

TD-LEAH-32-4 28 Aug 2024

DG->DD

HD-DEN-15104-1 14 May 2023

No longer needed.

HD-DEN-15274-1 14 May 2023

Done

HD-DEN-15274-1 14 May 2023

Done. This indentation was picked by Code Composer Studios though.

HD-DEN-15274-1 14 May 2023

Done

HD-DEN-15274-1 14 May 2023

I was thinking to send the command anyways. If the active reservoir is what we need, it will be ignored. But I changed the code.

HD-DEN-15274-1 14 May 2023

Done

HD-DEN-15274-1 14 May 2023

Done

HD-DEN-15274-1 14 May 2023

I changed the code.

HD-DEN-15274-1 14 May 2023

Done

HD-DEN-15274-1 14 May 2023

Done