•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-713-1 13 Jun 2025

Thanks for catching that.
Any subsystem can send the AlarmCleared, and that is why the Src is DPNDS (depends).
I changed the source to Any, and this is an Alarm Broadcast message.

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

UF pump has been labeled in the concentrate pump module. Does it have a temp sensor as well?

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed.

LEAHI-DIALIN-LDT-566-1 22 May 2025

Leahi?

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

Look to see if Vinay removed from f/w or ask Vinay if he intends to.

LEAHI-DIALIN-LDT-566-1 23 May 2025

I would describe the cmd param as ID of an ejector operation that is being requested.

LEAHI-DIALIN-LDT-566-1 23 May 2025

Mention the units (RPM) and that a negative speed = reverse (retract) direction.

LEAHI-APPLICATION-LDT-1021-1 23 Jun 2025

Do not anchor to the headerbar.

RO-LDT-566-1 23 Jun 2025

fixed thanks!

RO-LDT-566-1 23 Jun 2025

Remove extra line

LEAHI-APPLICATION-LDT-1021-1 23 Jun 2025

Why were these two lines removed?
By default, the stack item needs to fill in the parent.

LEAHI-DIALIN-LDT-566-1 23 May 2025

Wrong message ID.

RO-LDT-566-2 24 Jul 2025

Add comments to right.

LEAHI-APPLICATION-LDT-1733-1 24 Jul 2025

RESOLVED

HD-DEN-14892-3 12 May 2023

Why 2 of these?

TD-LDT-94-3 21 Apr 2025

Fixed.

HD-DEN-15104-1 12 May 2023

Removed

DG-DEN-15274-1 12 May 2023

Should be != TRUE?

HD-DEN-15274-1 12 May 2023

Use new #define from comment above.

DD-LDT-319-1 22 Apr 2025

Want Gen Dialysate mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

DD-LDT-319-1 22 Apr 2025

Done.

CLOUDSYNC-DEN-16690-1 15 Jul 2024

Merge branch 'DEN-16690-UI-MG-S117' into DEN-16839-UI-BN-Whitney-1B1
c88f546ad09c2d6c0222d8e694a9814e37a424ea
The follow up CR would be http://devapps.diality.us:8060/cru/CLOUDSYNC-DEN-16839-1
Will be closed.

DG-DENBUG-318-1 29 May 2025

Should we have before and after values in event data?

LEAHI-SW-LDT-261-2 29 May 2025

Please change this to U32.

TD-LEAH-32-4 28 Aug 2024

Do we still keep Syring pump for future use as place holder?

DD-LEAH-210-5 28 Aug 2024

Add a blank line before this comment.

DD-LEAH-210-5 28 Aug 2024

Add details for alarm cleared message sent.

DD-LEAH-210-5 28 Aug 2024

Remove extra blank line.

LEAHI-SW-LDT-261-2 28 May 2025
  • Please update to TD.
  • Update the message ID.
RO-LDT-332-1 24 Apr 2025

preGenWState is an input.

RO-LDT-332-1 24 Apr 2025

Have you added this function in message list ( MsgDefs.h and messaging.c)?

TD-LDT-469-1 20 May 2025

Fixed.

LEAHI-DIALIN-LDT-566-1 22 May 2025

Please add control as param (1: open loop, 0: Close loop)

LEAHI-APPLICATION-LDT-450-1 09 Jun 2025

remove space after '!'

LEAHI-APPLICATION-LDT-1516-1 28 Jul 2025

resolved.

TD-LDT-802-1 28 Jul 2025

Rename to "abortEjectorOperation".

LEAHI-SW-LDT-261-2 28 May 2025

Please update these to the following:

​    {Gui::GuiActionType::ID_AdjustVersionsHDRsp                     ,3*1+2+4*1+4}, // variable length parameters
    {Gui::GuiActionType::ID_AdjustVersionsDGRsp                     ,3*1+2+4*1+4}, // variable length parameters

We are also getting this fixed on the Denali.

LEAHI-APPLICATION-LDT-450-1 12 Jun 2025

RESOLVED

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed. thanks!

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed. thanks!

LEAHI-DIALIN-LDT-566-1 23 Jun 2025

fixed. thanks!

RO-LDT-566-1 24 Jun 2025

added

RO-LDT-566-2 30 Jul 2025

added to the documentation. thanks

LEAHI-APPLICATION-LDT-1730-1 24 Jul 2025

Good catch. I have those updated now

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

TD-LDT-736-1 28 Jul 2025

Why?

TD-LDT-802-1 28 Jul 2025

I tried to have the code as close as possible to the actual code. We can comment out if the VectorCAST ran into an issue.

TD-LDT-802-1 27 Jul 2025

Why is this file deleted?

RO-LDT-566-2 30 Jul 2025

to discuss in the in person meeting for CR.

RO-LDT-566-2 24 Jul 2025

Why do we need to set a pending flag if we're making the mode transition here?