•  

Comment Results

Review Name Created Custom Fields Content
TD-LDT-802-1 31 Jul 2025

Use alarmStatus structure to check whether alarm resume is allowed. proprs only looks at the passed alarm.

RO-LDT-566-2 01 Aug 2025

I don't see any inputs.

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

Group this with the other properties above.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

Align spacing after colon with other properties.

RO-LDT-566-2 01 Aug 2025

Remove blank line.

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Remove reference to VHDAirBubbleData.cpp

DD-LDT-1473-1 04 Aug 2025

it is moved to DDDef.h, UI team is looking for this mapping for their (diagnostics page) development.

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 04 Aug 2025

Please do not use any std code, and use Qt only.
If I recall correctly on this function behavior, you should be able to use the qBound(lowerBound, value, upperBound);
And also, do not use auto for basic types.
The auto is generally used in our coding for long iteration template types and lambdas.

LEAHI-APPLICATION-LDT-1788-1 05 Aug 2025

updated to use qBound

LEAHI-SW-LDT-907-2 04 Aug 2025

What are these values, and where are they used?

LEAHI-APPLICATION-LDT-1788-1 04 Aug 2025

the alarmDialogHeight should be the application height minus the HeaderBar.hight and MainMenu(bottom menu).height, if you would like a minimumgap*2 to get a little smaller to avoid exact overlap.
So we are using as much as we can but not covering the top, bottom menus.
and we can have the same left, right margin.

LEAHI-APPLICATION-LDT-1536-1 07 Aug 2025

Remove semicolon.

DD-LDT-1873-1 08 Aug 2025

Why?

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

yes updated and removed timer

RO-LDT-1809-3 27 Aug 2025

Change to ( skipSet != TRUE )

DD-LDT-2030-1 27 Aug 2025

Are these faults considered POST faults or periodic faults? I think in Denali the general ranking was:
Rank 1 is for TD POST faults
Rank 2 is for DD POST faults
Rank 10 is for TD faults
Rank 110 is for DD faults

DD-LDT-2030-1 27 Aug 2025

Move up a bit with other monitors/controllers.

UI-DEN-16953-1 16 Jul 2024

Done

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

Alarm should be handled inside of setAirPumpState().

TD-LEAH-32-4 28 Aug 2024

Fixed.

HD-DEN-15104-1 12 May 2023

Cut and paste error from DG. Corrected.

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

Alarm should be handled inside of setAirPumpState().

HD-DEN-15104-1 12 May 2023

Why aren't these declared at top of file and initialized in init function like everything else.

HD-DEN-15274-1 12 May 2023

I think there are cases where rsrvrCmd is not set and so we should not be calling this function in those cases.

DD-LEAH-210-5 29 Aug 2024

Fixed

TD-LEAH-32-4 28 Aug 2024

\b alarm (to bold

TD-LDT-469-1 20 May 2025

Added.

DD-LEAH-210-5 30 Aug 2024

Done. deleted unused function prototypes.

TD-LEAH-32-4 03 Sep 2024

Done.

TD-LEAH-32-4 03 Sep 2024

Done.

DD-LEAH-220-2 16 Sep 2024

This is just added for the sake of code review creation, the actual changes were already merged in to staging.

TD-LEAH-32-4 03 Sep 2024

Renamed to DD fault.
I think an RO fault can share the DD fault property since I imagine an RO fault would cause the DD to go to fault mode.

TD-LEAH-32-4 03 Sep 2024

Done.

DG-DENBUG-318-1 21 May 2025

I don't see the flag being set in this function.

DD-LEAH-210-5 03 Sep 2024

Done.

TD-LEAH-32-4 30 Aug 2024

Need to add DD and RO.

DD-LEAH-210-5 29 Aug 2024

Move this comment down below the pragma and use 3 slashes so doxygen picks it up.

DD-LEAH-210-5 29 Aug 2024

Why not include this?

TD-LEAH-41-1 16 Sep 2024

Added new alarm and uncommented.

TD-LDT-802-1 28 Jul 2025

I changed it back to energized state.

HD-DENBUG-318-1 21 May 2025

RESOLVED in CODE WALKTHROUGH

DIALIN-DENBUG-318-1 20 May 2025

This is a maximum, right? Change to _DEFAULT_MAX_RO_REJECTION_RATIO.

TD-LDT-469-1 19 May 2025

Please add header.

TD-LDT-469-1 19 May 2025

Update header

TD-LDT-469-1 19 May 2025

Current Eject motor set speed?

TD-LEAH-41-1 16 Sep 2024

Fixed.

TD-LDT-469-1 19 May 2025

DD. Search DG and replace in file.

TD-LEAH-41-1 16 Sep 2024

U08 to U32.