•  

Comment Results

Review Name Created Custom Fields Content
RO-LDT-566-2 01 Aug 2025

fixed. thanks

RO-LDT-566-2 01 Aug 2025

Shouldn't this unit be deleted since it's been renamed?

RO-LDT-566-2 01 Aug 2025

Remove extra blank line.

RO-LDT-566-2 01 Aug 2025

Remove blank line.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

RO-LDT-566-2 01 Aug 2025

Remove blank line.

RO-LDT-566-2 01 Aug 2025

Remove blank line.

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Filename and class name (and all references to class name in file) do not match.
sources/canbus/MessageInterpreter.cpp will need to be updated when class name changes.

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

same as http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-907-2CFR-69439

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 05 Aug 2025

updated

LEAHI-APPLICATION-LDT-1788-1 05 Aug 2025

updated

DD-LDT-1873-1 08 Aug 2025

these changes made for testing purposes. reverted to original.

DD-LDT-1873-1 08 Aug 2025

Done.

LEAHI-APPLICATION-LDT-1788-1 04 Aug 2025

Use a simple switch case, without a default case on the role enum.

RO-LDT-1809-3 27 Aug 2025

changed

DG-DEN-15246-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-16931-1 15 Jul 2024

Incorrect branching.
Branch deleted.
The CR would be http://devapps.diality.us:8060/cru/DIALIN-DEN-16931-2
will be closed.

TD-LDT-94-3 21 Apr 2025

Fixed.

HD-DEN-15104-1 12 May 2023

They were used when FE OE generated software fault. Removed.

HD-DEN-15104-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

TD-LDT-94-3 21 Apr 2025

Done.

TD-LDT-94-3 21 Apr 2025

Done.

TD-LEAH-32-4 28 Aug 2024

looks this feature is not supported in Leahi ( per last discussion On power management review)??

TD-LEAH-32-4 28 Aug 2024

Needs to be updated - TD FPGA ID.

DD-LEAH-210-5 28 Aug 2024

Add details for trigger message sent.

DD-LEAH-210-5 28 Aug 2024

Remove extra blank line.

DD-LEAH-210-5 28 Aug 2024

In TD, I removed the comments on every 5th enum and instead explicitly enumerated each one. Recommend we do that here too.

TD-LDT-94-3 22 Apr 2025

These get set (lines 485 and 488) before they are used (line 491). No need to initialize before then.

TD-LDT-94-3 22 Apr 2025

RESOLVED.

DD-LDT-319-1 22 Apr 2025

Signal Pre Gen mode and let it request standby mode.

DD-LDT-319-1 22 Apr 2025

Should signal Gen Dialysate mode and let it request transition to standby.

DD-LDT-319-1 22 Apr 2025

I think these two conditions above the switch statement should end the state processing.
So the second condition should be an else if and combined i.e. if ( ( genDialysateState != DD_GEND_DIALYSATE_DELIVERY_PAUSE ) && ( TRUE == areInletWaterConditionsAlarmsActive() ) ).
And then another else where the switch statement should go.
Hydraulic chamber and updating treatment settings should maybe be moved above all of this so they always happen.

DD-LDT-319-1 22 Apr 2025

Remove extra blank line.

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

HD-DENBUG-318-1 20 May 2025

This is not really a rej ratio - it's a maximum reg ratio. We should make that clear in naming #defines, field names, etc...

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

RO-LDT-332-1 24 Apr 2025

Remove extra blank line.

TD-LDT-469-1 20 May 2025

Fixed.

TD-LDT-469-1 19 May 2025

Update Message ID and I/O sections.

TD-LDT-469-1 19 May 2025

Fill in outputs.

RO-LDT-566-1 23 Jun 2025

Right brackets are all over the place. Please align.

LEAHI-SW-LDT-261-2 30 May 2025

RESOLVED

LEAHI-SW-LDT-261-2 29 May 2025

Please update the CAN ID ( AKA channel ) according to the following table from the following link (should be 0x100 since the DST is All/Broadcast):
Also, on the other models.

Channel Description
1 TD Alarm Broadcast
2 DD Alarm Broadcast
3 FP Alarm Broadcast
4 UI Alarm Broadcast
10 TD to DD
11 DD to TD
20 DD to FP
21 FP to DD
40 TD to UI
41 UI to TD
101 DD to UI
103 UI to DD
100 TD Broadcast
101 DD Broadcast
102 FP Broadcast
103 UI Broadcast
400 Dialin to TD
401 TD to Dialin
402 Dialin to DD
403 DD to Dialin
404 Dialin to FP
405 FP to Dialin

https://easydialhdbs.sharepoint.com/:x:/r/sites/FCRProject/Shared%20Documents/General/06_Software%20Design/05_Software_Design/Leahi%20Message%20List.xlsx?d=w8e3cf6a72be24bb882c6098b124bb2c5&csf=1&web=1&e=ozZVi0&nav=MTJfJEEkMTokQiQyM197RTQwREIyRkItMjI5NS00MDM3LTk3MEItOTUzNTg4Qzg4NjUzfQ

LEAHI-SW-LDT-261-2 28 May 2025

Add TODO.

  • Here
  • Model class description
LEAHI-DIALIN-LDT-261-1 28 May 2025

Thanks
RESOLVED

LEAHI-DIALIN-LDT-261-1 28 May 2025

Thanks
RESOLVED

LEAHI-APPLICATION-LDT-450-1 09 Jun 2025

This code is still in the early stage of development, and the debug codes are helpful to keep.

LEAHI-APPLICATION-LDT-450-1 12 Jun 2025

RESOLVED