•  

Comment Results

Review Name Created Custom Fields Content
RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 23 Jul 2025

No return.

RO-LDT-566-2 23 Jul 2025

Add blank line before return.

RO-LDT-566-2 23 Jul 2025

FPFaultMode

RO-LDT-566-2 24 Jul 2025

Not an output.

RO-LDT-566-2 01 Aug 2025

If no comment here, remove.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

aligned

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

updated

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

If defaultImagePath is only used here, then might be better to just construct the string here instead of declare and set the defaultImagePath variable above.

DG-DEN-15246-1 11 May 2023

Done

TD-LDT-94-3 21 Apr 2025

Fixed.

DD-LDT-319-1 21 Apr 2025

Done.

HD-DEN-15104-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1 12 May 2023

Are these used anywhere?

HD-DEN-15104-1 12 May 2023

I think these variable declarations should stay here. Why move to function?

CLOUDSYNC-DEN-16951-1 15 Jul 2024

Cherry picked in the DEN-16839-UI-BN-Whitney-1B1.
b53f9e9ad7304e8be3c516517ed1d06d775633b1
The follow up CR would be http://devapps.diality.us:8060/cru/#CLOUDSYNC-DEN-16839-1CFR-57808
Will be closed.

DD-LDT-319-1 21 Apr 2025

Done.

TD-LDT-94-3 21 Apr 2025

TD

TD-LDT-94-3 22 Apr 2025

RESOLVED.

TD-LDT-94-3 22 Apr 2025

this init is already being called in operationmode.c's init function. Do we need the redundancy?

DD-LDT-319-1 22 Apr 2025

Done.

DD-LDT-319-1 22 Apr 2025

Same as Gen Dialysate - this should be else if and switch statement should be in a final else.

DD-LEAH-210-5 28 Aug 2024

HD s/b DD.

DD-LEAH-210-5 28 Aug 2024

Remove drain pump and RTC includes. Reorder alphabetically.

DD-LEAH-210-5 28 Aug 2024

Change DG to DD.

TD-LEAH-32-4 27 Aug 2024

Alarm Audio.

TD-LEAH-32-4 28 Aug 2024

DG -> DD. may clean up in entire file.

DD-LEAH-210-5 28 Aug 2024

Add details for alarm condition cleared message sent.

DD-LEAH-210-5 28 Aug 2024

Should be Vinay.

DD-LEAH-210-5 28 Aug 2024

I would remove all enums that aren't already in this code base.

RO-LDT-566-2 24 Jul 2025

Add param.

RO-LDT-332-1 24 Apr 2025

Is there a recirculation mode when there is no water generation (per system team state machine)? or recirculation handled part of sub state of Gen water mode (I guess the name of mode (GENW) sounds always generating water, better to have recirculation as a mode instead of sub state?)

DD-LDT-1473-1 01 Aug 2025

I have introduced two additional build flags in 'DDCommon.h' (ENABLE_ALARM_1 and ENABLE_ALARM_2) to currently stop triggering alarms due to hardware support etc., so. it should be safe for now. if still any specific alarms triggers, will try to disable those alarms.

RO-LDT-566-2 30 Jul 2025

The intention of this to override was to exercise the control loop state machine since this isnt the variable used to set the pwm, but one layer above. We already have the set pwm ( and dialin functionality ) in the fluid pump driver. Lets discuss in the in person meeting.

LEAHI-APPLICATION-LDT-1733-1 24 Jul 2025

Please make the precision a global, read-only constant value, such as ultrafiltration in Variables.

LEAHI-APPLICATION-LDT-1042-1 24 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1516-1 25 Jul 2025

updated

RO-LDT-566-2 23 Jul 2025

Add extra blank line before test support banner.

TD-LDT-802-1 27 Jul 2025

Add blank line between declarations and code.

DD-LDT-1473-1 28 Jul 2025

Done.

LEAHI-APPLICATION-LDT-1516-1 28 Jul 2025

resolved.

LEAHI-APPLICATION-LDT-1516-1 28 Jul 2025

resolved.

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

removed driver.

RO-LDT-566-2 23 Jul 2025

How do we get to pre-gen now?

RO-LDT-566-2 01 Aug 2025

I would put normal messages above Dialin messages in this list - basically ordering this list in msg enum order.

RO-LDT-566-2 24 Jul 2025

Add blank line before return.