•  

Comment Results

Review Name Created Custom Fields Content
RO-LDT-566-2 01 Aug 2025

Check inputs/outputs

RO-LDT-566-2 01 Aug 2025

Remove blank line.

RO-LDT-566-2 04 Aug 2025

Added TODO. It'll be implemented in the next branch regarding stop/pauses states and alarm requirements.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

Use attached property isCurrentItem?

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

If %1 is meant to be a directory, then change string to "%1/Alarms/".

RO-LDT-1809-3 11 Aug 2025

Why not use get function in these ifs?

RO-LDT-566-2 01 Aug 2025

Update inputs/outputs

LEAHI-APPLICATION-LDT-907-2 04 Aug 2025

Change to #include "VTDAirBubbleData.h"

LEAHI-APPLICATION-LDT-1788-1 05 Aug 2025

removed

LEAHI-APPLICATION-LDT-1536-1 01 Aug 2025

ModalDialog definition should not be in the headerBar.

LEAHI-APPLICATION-LDT-1536-1 01 Aug 2025

Make this a component.

DD-LDT-2030-1 26 Aug 2025

Change all references to "saline bolus" to "solution infusion". We might do it with saline or dialysate so we need to generalize the feature.

RO-LDT-1928-3 28 Aug 2025

Calling it regardless of hardware

RO-LDT-1928-3 27 Aug 2025

Follow up with Eliza on TODO question.

DD-LDT-1735-1 29 Aug 2025

Fixed.

DD-LDT-2030-1 29 Aug 2025

Done

DD-LDT-2030-1 27 Aug 2025

Where is 110?

LEAHI-APPLICATION-LDT-2071-1 29 Aug 2025

updated here and in MTreatmentAdjustRequests.h

DD-LDT-2030-1 29 Aug 2025

Done

RO-LDT-1242-1 28 Aug 2025

Align "=".

UI-DEN-16953-1 16 Jul 2024

Please see http://devapps.diality.us:8060/cru/UI-DEN-16953-2 for ui.config review.

RO-LDT-332-1 24 Apr 2025

PRS is stating that it would be a sub state of water generation mode. Its also unsure if it will be required at the moment. With it being not too defined, I didnt think it was a good idea to implement it in this epic

LEAHI-TD-FIRMWARE-LDT-3126-1 02 Mar 2026

Updated to else part

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

TD-LEAH-32-4 28 Aug 2024

Reg 07 & 09? may need to update following register series.

HD-DEN-15104-1 12 May 2023

Is there more to be done here (TODO)?

DD-LEAH-210-5 28 Aug 2024

DD has no LEDs.

TD-LEAH-32-4 28 Aug 2024

file name CpldInterface.c

LEAHI-TD-FIRMWARE-LDT-1903-8 02 Mar 2026

This structure doesn't seem necessary - it's just a middle man. Why not just pass the #defines directly into the quadratic macro?

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

LEAHI-APPLICATION-LDT-1730-1 24 Jul 2025

RESOLVED

HD-DEN-15104-1 12 May 2023

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

HD-DEN-15104-1 12 May 2023

There are enums for the valves. However, the enum value does not correspond to their position in the valve status returned from the FPGA. For example, VDI is enumerated to be the first value in the enum but is the second 2nd group of 3 bits (0 relative) returned by the FPGA.

LEAHI-DIALIN-LDT-3557-1 03 Mar 2026

Remove this extra line

HD-DEN-15104-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1 12 May 2023

Remove blank line.

LEAHI-APPLICATION-LDT-1516-1 25 Jul 2025

updated to center the modalDialog and adjust the y on the Treatmentadjustmentbase

HD-DEN-15104-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

LEAHI-TD-FIRMWARE-LDT-3126-1 03 Mar 2026

This should be invalid state (or something like that).

LEAHI-APPLICATION-LDT-1516-1 25 Jul 2025

tested with the simulator and the header menu does hide when in blood prime

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

DD-LDT-1473-1 27 Jul 2025

Capitalize the p.

DD-LDT-1473-1 27 Jul 2025

Looks like you are calculating iteration in "mL/5sec", not "mL/sec".

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

updated in renamed file. thanks!

RO-LDT-566-2 30 Jul 2025

Agreed. Renamed the common file names ( standby, op modes, fault, post ) with a FP prefix.

TD-LDT-802-1 01 Aug 2025

Done

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

RESOLVED

TD-LDT-802-1 28 Jul 2025

I think we should only stop pump and go to abort state if an operation is in progress. Look at current state to see if we need to abort anything.