•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15274-1 14 May 2023

Done

HD-DEN-15104-1 14 May 2023

Moved to here from function.

DG-DEN-15274-1 14 May 2023

Done

DG-DEN-15274-1 14 May 2023

Done

HD-DEN-15104-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-15274-1 14 May 2023

I had not pushed them.

DIALIN-DEN-15274-1 14 May 2023

RESOLVED.

HD-DEN-15274-1 14 May 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15274-1 14 May 2023

Fixed it.

DG-DEN-15274-1 14 May 2023

Remove blank line?

DG-DEN-15274-1 14 May 2023

Done

DG-DEN-15274-1 14 May 2023

Let's put test config conditions last when mixing with normal conditions (both ifs).

DG-DEN-15274-1 14 May 2023

Done

DG-DEN-15274-1 14 May 2023

Done

DG-DEN-15274-1 14 May 2023

Yes eventually!

DG-DEN-15274-1 14 May 2023

Done

DG-DEN-15274-1 14 May 2023

Done

DG-DEN-15274-1 14 May 2023

Done

DG-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15274-1 14 May 2023

Disagree with comment change.

DG-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15274-1 14 May 2023

Remove comment?

DG-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15274-1 14 May 2023

Comment for function.

DG-DEN-15274-1 14 May 2023

Extra blank line.

HD-DEN-15229-1 14 May 2023

Not needed if we do this in prior state.

UI-DEN-15287-3 15 May 2023

Alignment of ); break;

HD-DEN-15229-1 14 May 2023

Once we leave this state, we've done the door open/close that we were looking for - so should start requiring door to be closed from this point forward.

HD-DEN-15229-1 14 May 2023

I think we still want to get credit for opening the door in this state - and so need to be okay with door opening (not required to be closed) and so probably should be calling your door handler here.

HD-DEN-15229-1 14 May 2023

Should probably set confirm flag to FALSE here even though it probably gets reset at some point before next treatment.

HD-DEN-15229-1 14 May 2023

Not sure we need this in this state if we require door to be closed in this state.

HD-DEN-15274-1 14 May 2023

RESOLVED in CODE WALKTHROUGH.

TD-LDT-469-1 20 May 2025

Fixed.

TD-LEAH-32-4 28 Aug 2024

Fixed.

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

updated and defined variables in this file as its only used here

HD-DEN-15196-2 15 May 2023

Blood prime and treatment start sub modes dont have a substate. The call here will cover the treatment start sub mode. Blood prime will be covered in the transition to blood prime

HD-DEN-15196-2 14 May 2023

Not clear to me which of the older events are still being supported. What's the plan?

HD-DEN-15196-2 15 May 2023

I don't see fix.

DD-LEAH-210-5 29 Aug 2024

The 'valveStatesPublishInterval' is override variable. this variable remains unchanged.

HD-DEN-15196-2 15 May 2023

RESOLVED IN CODE WALKTHROUGH

DG-DENBUG-318-1 20 May 2025

max ratio