Change to "... the measured flow rate for a given concentrate pump."
I thought we were using "\b Message \b Sent:", not "\b Messages:".
Why not initialize to lastBaroTempReadCounter.data as assigned below? Then we don't need assignment below.
Remove blank line.
Module to unit.
RESOLVED in CODE WALKTHROUGH.
Removed.
I don't understand either of these TODOs. Are they needed?
Should you do something with the received max ratio? It's local, so it's just being dropped.
I'm just going to follow HDD. If Noe removes these registers or re-purposes them, I will follow suit. If he leaves them in, I'll do the same.
Where is this enumeration defined?
You are not doing double buffers. Remove this note.
Looks we need these variables as global variables since the execvalve checks the last command valve and read back valve state to report an alarm. To retain the last commanded valves, we need these variables as global.
Done
RESOLVED.
Do we need to uncomment this line and change alarm name as TD?
Move constants and structs up to definitions section.
this might be clearer written as: data = MAX( 0.0F, data )
Done.
It is an input - don't remove flag there. It is not an output - so remove it there.
pre gen?
Are we going to generate design document out from the code? if so, can we add doxygen headers/group for all .c/.h files?
Add more details.
Change sensors' to sensor. And let's not abbreviate words like structure in doxygen comments.
Add s/w fault.
Should only have to call FpgaDD.h init function from main to get low-level driver init function called from there.
Dara's build script should be updating these for us.
DDPreGenDialysate?
Update message list spreadsheet to include new fields.
Where are the messages for conductivity and pressure overrides? Are you looking for Michael to add those?
are we not publishing the buttons state?
It has not been requested.
Can we remove this now?
"... interval override for post gen dialysate data."
Why is this infinite loop needed (or even wanted)?
Doxygen comment needed.
pre gen
same comment.
Seems like more is happening here than init. Some resetting too.
Shouldn't these be in user code (2)?
If send fails, I think we abort, try to send error msg to UI, and go back to standby.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
