•  

Comment Results

Review Name Created Custom Fields Content
TD-LDT-469-1 20 May 2025

Fixed.

HD-DEN-15196-2 15 May 2023

Fixed. Thanks!

HD-DEN-15196-2 15 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15196-2 15 May 2023

I don't see fix.

DIALIN-DENBUG-318-1 21 May 2025

RESOLVED

HD-DEN-15229-1 15 May 2023

Removed

DD-LEAH-210-5 29 Aug 2024

Will be addressed once Concentrate pump driver is included. this function carries the parameter (#define) related to concentrate pump.

HD-DEN-15229-1 15 May 2023

Doesn't make sense to reset in previous state. You're resetting door opened flag there. I'm talking about patient connect confirm flag used in if statement above.

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15229-1 15 May 2023

Correct, no longer required. Removed.

DD-LEAH-210-5 29 Aug 2024

Done.

HD-DEN-15274-1 16 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15229-1 16 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15274-1 16 May 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15274-1 17 May 2023

Done

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 30 Aug 2024

Done.

TD-LEAH-32-4 28 Aug 2024

Can we shift this into app/driver level code, so that every time we don't touch hal code when we add any new init code? thinking about additional level abstraction (One Init function calls all of these inits and that alone be exposed to hal.) ??

LEAHI-DIALIN-LDT-566-1 22 May 2025

Leahi?

DD-LEAH-210-5 30 Aug 2024

Done.

LEAHI-DIALIN-LDT-566-1 22 May 2025

same.

TD-LEAH-32-4 28 Aug 2024

Fixed.

DD-LEAH-210-5 29 Aug 2024

Done.

DD-LEAH-210-5 29 Aug 2024

Done.

TD-LEAH-41-1 16 Sep 2024

U08 to U32.

DD-LEAH-210-5 30 Aug 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

DD-LEAH-210-5 03 Sep 2024

Done.

TD-LEAH-32-4 04 Sep 2024

Correct.

DD-LEAH-210-5 29 Aug 2024

I think using component code in function names is good, but not in the actual text that is describing the function.

DD-LEAH-210-5 29 Aug 2024

I don't think Interrupts or Utilities is needed here.

DD-LEAH-210-5 30 Aug 2024

No chem disinfect.

DD-LEAH-210-5 04 Sep 2024

RO and DD will be via FPGA, but otherwise should be handled the same (e.g. same pins).
Let's consider this later.

DD-LEAH-220-2 17 Sep 2024

Done.

DG-DEN-17053-6 16 Sep 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-17053-6 13 Sep 2024

Do not put colons after params.

DG-DEN-17053-6 16 Sep 2024

RESOLVED in CODE WALKTHROUGH.

TD-LEAH-41-1 16 Sep 2024

unit instead of module.

TD-LEAH-41-1 16 Sep 2024

looks exec bubble called in priority task. need to update priority task interval.

TD-LEAH-47-1 26 Sep 2024

Fixed.

TD-LEAH-47-1 25 Sep 2024

initilalizes the Airpump driver? Also, the outputs to mention unit variables initialized instead detailed list.

TD-LEAH-47-1 25 Sep 2024

extra blank line

DD-LEAH-227-1 30 Sep 2024

This is not an output - it is what gets returned which is already covered below.

DD-LEAH-227-1 30 Sep 2024

Change to "TRUE if the given concentrate pump is currently parked, FALSE if not."

DD-LEAH-227-1 30 Sep 2024

Change "... the concentrate pump ..." to "... the given concentrate pump ...".

BOOTLOADER-LEAH-1415-1 30 Sep 2024

Done

DD-LEAH-227-1 30 Sep 2024

Is this measured speed or measured flow? The function header says it's mL/min, so should be flow if that is the case.

DD-LEAH-227-1 30 Sep 2024

Too broad. At least narrow down to "temperature sensor readings from FPGA".

DD-LEAH-227-1 30 Sep 2024

elapsedTime seems more like a start time.