•  

Comment Results

Review Name Created Custom Fields Content
RO-LDT-566-2 01 Aug 2025

If not ready to implement this unit, should we remove it for this branch?

RO-LDT-566-2 01 Aug 2025

Remove extra blank line.

RO-LDT-566-2 01 Aug 2025

Remove blank line.

DG-DEN-15246-1 11 May 2023

Then the one above with 100 comment is wrong.

TD-LDT-94-3 21 Apr 2025

Please add message sent.

UI-DEN-16951-26 15 Jul 2024

cherry picked into the DEN-16839-UI-BN-Whitney-1B1
63c6fe7fab869eebdad66b970b3b3ab8e4c5e046
The CR would be http://devapps.diality.us:8060/cru/#UI-DEN-16839-2CFR-57138
will be closed.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

Related comment.

TBDL: Let's discuss more later.

HD-DEN-14892-3 12 May 2023

I don't see these two functions in the .c file. Are they not yet implemented?

HD-DEN-15104-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1 12 May 2023

Make U32.

DIALIN-DEN-15274-1 12 May 2023

Missing 2 new configs.

HD-DEN-15274-1 12 May 2023

Comment for what we're doing here.

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

TD-LEAH-32-4 27 Aug 2024

Fixed.

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

TD-LEAH-32-4 27 Aug 2024

Fixed.

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

DG-DENBUG-318-1 20 May 2025

Done

HD-DENBUG-318-1 20 May 2025

Done

DG-DENBUG-318-1 21 May 2025

Done

TD-LEAH-32-4 27 Aug 2024

Fixed.

LEAHI-APPLICATION-LDT-1730-1 24 Jul 2025

good catch. pushed an update

LEAHI-DIALIN-LDT-566-1 22 May 2025

This command is used to directly override the "pendingStoptDDPregenRequest" flag (which is also set when TD proxy command executed when all pre-conditions met).

LEAHI-DIALIN-LDT-566-1 22 May 2025

DDPostGenDialysate?

DD-LEAH-210-5 27 Aug 2024

Driver. Please describe a little more.

DD-LEAH-210-5 27 Aug 2024

In TD, I removed this unit and merged safety shutdown content into GPIO and CPLD Interface (would be FPGA Interface for DD and RO) units.
I don't see that you have a GPIO unit, but you should I think. It would have watchdog and safety shutdown pin defs, macros, and functions.

DD-LEAH-210-5 28 Aug 2024

DD has no reservoirs or RTC.

DD-LEAH-210-5 28 Aug 2024

DD has no UV reactors.

DD-LEAH-210-5 28 Aug 2024

Remove "passed" from comment. We are broadcasting regardless of pass/fail.

DD-LEAH-210-5 28 Aug 2024

Replace HD in all comments with TD.

DD-LEAH-210-5 28 Aug 2024

Generalize initialization outputs.

TD-LEAH-32-4 27 Aug 2024

typo: alarm rank table.

TD-LEAH-32-4 27 Aug 2024

Need to add Params.

TD-LEAH-32-4 27 Aug 2024

Alarm for DD and RO.

TD-LEAH-32-4 27 Aug 2024

Alarm for DD and RO.

TD-LEAH-32-4 27 Aug 2024

AlarmLamp - rename as AlarmAudio

TD-LEAH-32-4 28 Aug 2024

Not matching function names. check the below functions header as well.

DD-LEAH-210-5 28 Aug 2024

Remove this.

TD-LEAH-32-4 28 Aug 2024

Needs title and author/date update

RO-LDT-566-2 23 Jul 2025

Remove extra blank line.

RO-LDT-566-2 30 Jul 2025

functions have been removed as we no longer need it

TD-LDT-736-1 29 Jul 2025

Fixed.

DD-LDT-1473-1 27 Jul 2025

Remove extra blank line.

DD-LDT-1473-1 28 Jul 2025

With the updated FPGA logic for continuous flow rate, doesn't need this variable anymore.

LEAHI-APPLICATION-LDT-1516-1 24 Jul 2025

move the y change to the dialogs inside the stacks and revert the globla dialog y changes

LEAHI-APPLICATION-LDT-1516-1 24 Jul 2025

make visible always and remove visible key

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

removed

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

Sorry, yes you are correct, it is just using the defaults.
Should the commented portion be removed though?

TD-LDT-736-1 28 Jul 2025

space needed in sizeof( BOOL ). Follow the same for line no : 526.