•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15104-1 12 May 2023

Now it's gone. No longer needed?

HD-DEN-15104-1 12 May 2023

Why is this in two places? And why set every 10ms when it appears to be constant?

HD-DEN-15104-1 12 May 2023

Not a fan of in function statics. Probably due to Vectorcast having a hard time initializing them before function is called. Please avoid doing this.

HD-DEN-15104-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1 12 May 2023

Use enums instead of literals.

UI-DEN-16657-15 15 Jul 2024

Merged branch 'DEN-16657-UI-BN-S116-LogUpload-Compression' into DEN-16839-UI-BN-Whitney-1B1
a5e7c87b63a7b2d601fe02fb3e10a8ff6758ed59

Will be closed.

TD-LDT-94-3 21 Apr 2025

Fixed.

CLOUDSYNC-DEN-16690-1 02 Aug 2024

RESOLVED

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

RESOLVED

TD-LDT-94-3 21 Apr 2025

Fixed.

DD-LDT-319-1 21 Apr 2025

Done.

TD-LDT-94-3 21 Apr 2025

Add alarm/event.

DD-LDT-319-1 22 Apr 2025

Done.

DD-LDT-319-1 22 Apr 2025

stop should be capitalized.

TD-LEAH-32-4 28 Aug 2024

Fixed.

DD-LEAH-210-5 27 Aug 2024

Add blank line between doxygen group item and definitions.

DD-LEAH-210-5 27 Aug 2024

Add blank line between library includes and app includes. Library includes should come first, so FpgaDD.h above should come down into the app includes group and should have "" instead of <>. App includes should be in alphabetical order.

DD-LEAH-210-5 27 Aug 2024

Same comment. If only open and closed state names, we don't really need this function.

DD-LEAH-210-5 27 Aug 2024

Remove blank line.

DD-LEAH-210-5 27 Aug 2024

Make 2 blank lines before and after test support functions banner.

DD-LEAH-210-5 27 Aug 2024

valveStates[].

DD-LEAH-210-5 28 Aug 2024

FpgaDD.h.

DD-LEAH-210-5 28 Aug 2024

Remove - no LEDs on DD.

TD-LEAH-32-4 27 Aug 2024

add in Outputs: alarmIsDetected[]

TD-LEAH-32-4 27 Aug 2024

function name needs to be updated.

DD-LEAH-210-5 28 Aug 2024

Make this comment an inline like the others.

RO-LDT-566-2 23 Jul 2025

Add isFlushComplete to inputs.

LEAHI-APPLICATION-LDT-1516-1 24 Jul 2025

RESOLVED

TD-LDT-802-1 28 Jul 2025

Done

TD-LDT-802-1 28 Jul 2025

Done

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

RESOLVED

RO-LDT-566-2 30 Jul 2025

fixed.

RO-LDT-566-2 30 Jul 2025

fixed thanks!

RO-LDT-566-2 30 Jul 2025

fixed thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks

RO-LDT-566-2 30 Jul 2025

i believe they are.. this driver will have to be reviewed once we get the conductivity sensors onto the units.

getFPGAP9Data() pulls register 336 in the HDD that is 4 bytes.
getFPGAP9Conductivity pulls register 340 that is 2 bytes.
getFPGAP9Temperature pulls register 342 that is 2 bytes.

unsure what are the differences between getFPGAP9Data and the other two. Seem like they are the same

RO-LDT-566-2 23 Jul 2025

Add s/w fault alarm.

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 22 Jul 2025

Not sure this should be overridable. Can still have Dialin set this, but with a set command (instead of an override command). If you allow override, can get into situation where target needs to be programmatically changed (e.g. zeroed when changing control method) and it only changes the .data and not the .ovdata and, if currently overridden, it's not zero and doesn't work right.
General rule:
-use override cmds for sensor readings and broadcast intervals (i.e. things that you get or are usually constant)
-use set cmds for set points and targets (i.e. things that you set)

RO-LDT-566-2 01 Aug 2025

Remove extra blank line.

RO-LDT-566-2 23 Jul 2025

Remove extra blank line.

RO-LDT-566-2 01 Aug 2025

This is the deleted file. Moved to FPModeStandby

RO-LDT-566-2 24 Jul 2025

Not an input.

RO-LDT-566-2 01 Aug 2025

fixed. Thanks!

TD-LDT-802-1 01 Aug 2025

Done

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

no you are right.. removed extra container component

RO-LDT-566-2 01 Aug 2025

Remove extra blank line.

RO-LDT-566-2 01 Aug 2025

Remove extra blank line.

DG-DEN-15246-1 04 May 2023

This function could, in theory, be used to assign a CD2 cal table to CPo (for example).

DG-DEN-15246-1 04 May 2023

Probably not needed, but for good measure can we do this in transition to GenIdle mode too?