•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15274-1 12 May 2023

case body should be indented.

HD-DEN-15274-1 12 May 2023

Put this prototype declaration last w/ blank line before.

TD-LDT-94-3 21 Apr 2025

Please add alarm.

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

HD-DEN-16851-1 01 May 2024

Should be a F32 since it's an average. Comment should say 10s or something generic.

HD-DEN-16851-1 01 May 2024

Change to "bloodPumpPartialOcclusionBaseline".

HD-DEN-16851-1 01 May 2024

0.0F.

HD-DEN-16851-1 01 May 2024

Must be in dialysis state and stage 2 or stable pressure state.

HD-DEN-16565-1 24 May 2024

Bootloader seems to be executed in supervisory mode. if so, the current allocated stack for supervisory mode is 1K (if we merge into existing HD/DG firmware). we may need to watch for supervisory mode stack size, in case boot loader consumes more that 1K?

RO-LDT-332-1 24 Apr 2025

I think these should be // TODOs. We're just not doing anything yet.

HD-DEN-16851-1 02 May 2024

Done.

HD-DEN-16851-1 02 May 2024

Casting not necessary.

HD-DEN-16851-1 02 May 2024

Yes, if you cast either value in division as a F32, the result will be F32. This is all we need as F32 (the .data). The samples and total can stay U32.
You might want to cast the total as F32 as well for consistency.

RO-LDT-332-1 24 Apr 2025

Inputs should be "none".

UI-DEN-16860-1 10 May 2024

Done

RO-LDT-332-1 24 Apr 2025

Let DD interface send a signal to pre-gen mode and pre-gen mode state machine handling switching to standby mode (after stopping actuators etc.). Please follow the same for below function as well.

UI-DEN-16860-1 10 May 2024

RESOLVED

UI-DEN-16816-1 14 May 2024

Is this comment still valid ?

RO-LDT-566-2 23 Jul 2025

Add blank line after banner.

DG-DEN-16680-1 01 Jul 2024

This flag is really indicating drain water is not too hot OR we are not doing a nocturnal heat disinfect. Flag name could be better.

DG-DEN-16565-1 24 May 2024

we need to take care of existing stack size while we merge the bootloader changes. the current stack size is 0x3400, not 0x4C00.

DG-DEN-16680-1 03 Jul 2024

RESOLVED in CODE WALKTHROUGH

HD-DEN-16565-1 06 Jun 2024

Why is bootloader executing in a different mode than app? Is that necessary? How will mode switch back to user when jumping to app?

DG-DEN-16680-1 01 Jul 2024

Thanks I meant medium priority. Changed the rank to 500.

HD-DEN-16680-2 27 Aug 2024

RESOLVED in CODE WALKTHROUGH.

UI-DEN-16657-7 15 Jul 2024

merged into http://devapps.diality.us:8060/cru/UI-DEN-16839-2
will close.

CLOUDSYNC-DEN-16657-3 02 Aug 2024

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-210-5 28 Aug 2024

Generalize initialization outputs.

TD-LEAH-32-4 27 Aug 2024

Fixed.

DD-LEAH-210-5 28 Aug 2024

Add details for event messages sent and s/w fault alarm.

DD-LEAH-210-5 28 Aug 2024

Not really a queue operation. But we want the mode and sub-mode to be updated together and the set is not atomic so we need thread protection.

DD-LEAH-210-5 28 Aug 2024

Add a details for event messages sent.

DD-LEAH-210-5 27 Aug 2024

Try to be a little more descriptive in these group briefs as this is the summary text in the SDD for the unit.
This is a driver and controller/monitor all in one.

TD-LEAH-32-4 27 Aug 2024

Remove extra semicolon

TD-LEAH-32-4 27 Aug 2024

typo: bulk.

DD-LEAH-210-5 27 Aug 2024

Add redundant enums for group separation (e.g. FIRST_UF_VALVE) so that this reads better.

DD-LEAH-210-5 28 Aug 2024

Remove this. DD will not have LEDs as far as I know.

DD-LEAH-210-5 28 Aug 2024

m at end of comment should be mode.

DD-LEAH-210-5 28 Aug 2024

Change DG/HD to DD/TD.

DD-LEAH-210-5 28 Aug 2024

Add details for event messages sent.

TD-LEAH-32-4 27 Aug 2024

No alarms in the function. check the below one as well.

HD-DEN-15199-1 09 May 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16680-1 01 Jul 2024

RESOLVED IN CODEWALKTHROUGH.

DG-DEN-15246-1 11 May 2023

Is this a big risk? At this time I am not too concerned about it. If you think it should be addressed, I can make changes.

DG-DEN-15246-1 11 May 2023

Done

DD-LEAH-210-5 28 Aug 2024

Just generalize outputs for init.

RO-LDT-332-1 24 Apr 2025

pendingStartGenRequest is an input.

RO-LDT-332-1 24 Apr 2025

DD should be FP.
preGenWExecState is an output.
genDialysateDataPublicationTimerCounter is an output.

DIALIN-DEN-16680-1 02 Jul 2024

Changed the location of the enums.

DG-DEN-16680-1 01 Jul 2024

Is this necessary in else? If so, can move above or below the if so you just do it once.