•  

Comment Results

Review Name Created Custom Fields Content
CLOUDSYNC-DEN-16690-1 09 Apr 2024

please push the code to resolve

CLOUDSYNC-DEN-16690-1 28 Mar 2024

does python have functionality/library to check for folder/file management/information to be used instead of the shell command by a subprocess?

HD-DEN-15229-1 12 May 2023

With that approach, we are likely to have pump/heater off for some time which will allow the dialysate to cool and perhaps cause a temperature alarm when we do start treatment.
I think we should have the pump/heater on when door is closed in patient connect states.

HD-DEN-15229-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15104-1 12 May 2023

This code is identical to the DG implementation. Initially they were only included in debug mode. Seemed like it made sense to move to function as they are only used in the function.

HD-DEN-16819-1 11 Apr 2024

Need for 2 heparin settings below as well.

DIALIN-DEN-16851-1 02 May 2024

Done.

HD-DEN-15104-1 12 May 2023

Per my other comment, please avoid in-function static variables.

HD-DEN-15104-1 12 May 2023

Add space between ( and TRUE. Or just remove condition and always set flag to FALSE here.

HD-DEN-15104-1 12 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15196-2 12 May 2023

Missing function header

DIALIN-DEN-16851-1 02 May 2024

Done.

HD-DEN-16851-1 02 May 2024

Done.

DIALIN-DEN-16851-1 02 May 2024

RESOLVED.

HD-DEN-16851-1 02 May 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16851-1 02 May 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16680-1 03 Jul 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16851-1 02 May 2024

I think we just want to publish the baseline here (not +1000).

HD-DEN-16856-1 08 May 2024

Done

DG-DEN-16565-1 06 Jun 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16680-1 01 Jul 2024

Removed \n

DG-DEN-16680-1 28 Jun 2024

Looks ALARM_PRIORITY_LOW ranks are in 700 to 800 series range. Medium priority rank ranging 400 to 600. Do you want to consider this as low priority or medium priority? if medium priority rank, can we get rank in to 400 to 600 series?

DG-DEN-16680-1 28 Jun 2024

Do we need "\n" after the " Turn of Inlet water valves."?

HD-DEN-16680-2 15 Jul 2024

This is just the active cool mode by itself.

DG-DEN-16680-1 02 Jul 2024

Removed the one in else.

DIALIN-DEN-16680-1 01 Jul 2024

Any reason why you're not putting these at end of enum so existing states can keep their enum #?

UI-DEN-16816-1 15 Jul 2024

This ticket was experimental.
will be closed.

UNITTEST-DEN-16931-1 15 Jul 2024

Unit Tests dose not need code review and the review is the reports.
No failed result and coverage higher than expected (70 for now).
Will be closed.

TD-LEAH-32-4 28 Aug 2024

Fixed.

UI-DEN-16953-1 23 Jul 2024

RESOLVED

UI-DEN-16953-1 15 Jul 2024

Please do not forget to add the ui.config here for review.

UI-DEN-16777-1 02 Aug 2024

RESOLVED.

CLOUDSYNC-DEN-16690-1 05 Aug 2024

RESOLVED on behalf of Behrouz NematiPour

DD-LEAH-210-5 27 Aug 2024

Shouldn't this be overrideable?

DD-LEAH-210-5 27 Aug 2024

I think these are going to be refactored. Message handlers need to return BOOL and take a message as a param. See TD BubbleDetector.c for example.

HD-DEN-16680-2 01 Jul 2024

We didn't have this before?

DD-LEAH-210-5 28 Aug 2024

DD has no load cells.

TD-LEAH-32-4 27 Aug 2024

Remove Internal ADC reference.

TD-LEAH-32-4 27 Aug 2024

Fixed.

TD-LEAH-32-4 27 Aug 2024

Fixed.

DD-LEAH-210-5 28 Aug 2024

Add details for event message sent.

HD-DEN-16680-2 27 Aug 2024

Param is wrong.

TD-LEAH-32-4 28 Aug 2024

Fixed.

TD-LEAH-32-4 27 Aug 2024

Generic name (XX) instead of TD.

DD-LEAH-210-5 28 Aug 2024

I don't think DD will have CPLD, drain pump, fans, or flow sensors.

DD-LEAH-210-5 28 Aug 2024

Remove cases for RTC, accelerometer, drain pump, reservoirs, UV reactors, fans, flow sensors, and load cells.

TD-LEAH-32-4 27 Aug 2024

empty comment section.

HD-DEN-15199-1 08 May 2023

Recommend being more direct in naming:
TEST_CONFIG_USE_WET_CARTRIDGE
TEST_CONFIG_USE_WORN_CARTRIDGE

DD-LDT-319-1 21 Apr 2025

postGenDialysateState is an input.

HD-DEN-16851-1 02 May 2024

Yes, when we are not in treatment mode, the state machine sets the state to "pressure_limits_state_off" at start of this function ( line : 673). hence mode check is not necessary.