•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-15104-1 12 May 2023

This is HD f/w. Why are you looking at DG mode?

DG-DEN-15274-1 12 May 2023

Declarations before code.

HD-DEN-15274-1 12 May 2023

Use new #define (from comment above).

TD-LDT-94-3 21 Apr 2025

Update I/O. please revisit across the file.

DD-LDT-319-1 21 Apr 2025

Add a condition that Dialin user is not logged into DD. If tester is logged in, we want to allow tester to set mode to whatever they want.

CLOUDSYNC-DEN-16690-1 09 Apr 2024

fixed. thanks!

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

CLOUDSYNC-DEN-16690-1 09 Apr 2024

Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.

CLOUDSYNC-DEN-16690-1 09 Apr 2024

Please push the fix so it can be resolved.

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

CLOUDSYNC-DEN-16690-1 09 Apr 2024

added exception handling for when the subprocess call fails. thanks

CLOUDSYNC-DEN-16690-1 09 Apr 2024

line 507 has the reassignment if we find that sd_used_bytes is 0

CLOUDSYNC-DEN-16690-1 28 Mar 2024

does split() always have index 0 ?
[index out of bounds]

TD-LDT-469-1 20 May 2025

Fixed.

HD-DEN-16842-1 26 Apr 2024

Done

HD-DEN-16842-1 26 Apr 2024

Update params.

DG-DENBUG-318-1 21 May 2025

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16842-1 26 Apr 2024

RESOLVED in CODE WALKTHROUGH.

TD-LDT-469-1 19 May 2025

ejector driver/module. Update the Outputs below.

LEAHI-DIALIN-LDT-566-1 22 May 2025

"... interval override for pre gen dialysate data."

LEAHI-DIALIN-LDT-566-1 23 May 2025

Some of these are floats, so should be 'f'.

DIALIN-DEN-16851-1 02 May 2024

Done.

HD-DEN-16851-1 02 May 2024

Done.

LEAHI-DIALIN-LDT-566-1 22 May 2025

same.

HD-DEN-16851-1 02 May 2024

Done.

HD-DEN-16851-1 02 May 2024

Done.

HD-DEN-16851-1 01 May 2024

Not needed if you only trigger alarm after 1st stage destabilization state.

HD-DEN-16851-1 01 May 2024

I think for partial occlusion, we need a separate 15 min timer and should not be a timeout - needs to be a timercounter so it can be paused when not in dialysis state.

HD-DEN-16851-1 02 May 2024

Done

HD-DEN-16851-1 02 May 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16851-1 02 May 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16851-1 02 May 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16862-1 08 May 2024

Disinfect should be higher priority than flush.

HD-DEN-16856-1 08 May 2024

RESOLVED IN CODEWALKTHROUGH.

RO-LDT-566-2 23 Jul 2025

No return value.

UI-DEN-16860-1 10 May 2024

remove this from her ( the base class ) and add it to the VDuetRoWaterDG.h

RO-LDT-566-2 23 Jul 2025

Remove blank line.

HD-DEN-16565-1 24 May 2024

Looks to be memory overflow to be occurred. src-> pointing the buffer of 4 bytes length. bytes-> mentioning 16 bytes length. g_pulUpdateSuccess[] should be allocated more than the current size. Also, Do we need to typecast "(uint32_t) bytes", since the api mentioning (uint8_t)?

Fapi_StatusType Fapi_issueProgrammingCommand(
uint32_t *pu32StartAddress,
uint8_t *pu8DataBuffer,
uint8_t u8DataBufferSizeInBytes,
uint8_t *pu8EccBuffer,
uint8_t u8EccBufferSizeInBytes,
Fapi_FlashProgrammingCommandType oMode)

HD-DEN-16778-1 24 May 2024

Once it goes into prime pause state -> say, user removes the clamping and resume the priming -> again this state executes to check the clamping condition. Now, venous pressure is in range and raw flow rate more than minimum, we get into else state with last set flag ( primeDialysateOcclusionDetected) and change the priming state back to blood priming initial states.

HD-DEN-16778-1 24 May 2024

Alarm above has stop property. So triggering alarm will take us out of this state and go to Prime Pause state. So this else will never happen I think.

CLOUDSYNC-DEN-16657-3 07 Apr 2024

This might cause a code smell in SonarQube.

HD-DEN-16565-1 24 May 2024

the second value is 0x00 or 0xFFFFFFFF?

The bootloader checks the value is not equal to 0xFFFFFFFF, if so, the valid application is not found, and firmware needs to be updated.

HD-DEN-15199-1 08 May 2023

This was updated but not pushed.

HD-DEN-16782-1 04 Apr 2024

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-15199-3 09 May 2023

RESOLVED.

TD-LDT-94-3 21 Apr 2025

Remove/update comment as required.

DD-LDT-319-1 21 Apr 2025

Align comment.

DG-DEN-15246-1 11 May 2023

This is 105.

DIALIN-DEN-16680-1 03 Jul 2024

RESOLVED.

CLOUDSYNC-DEN-16690-1 09 Apr 2024

Not that i found that wasnt third party. shutil helps us find the sd card size, but it cant do directory sizes