•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-15199-1 26 Apr 2023

RESOLVED in CODE WALKTHROUGH.

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

HD-DEN-14546-3 27 Apr 2023

The suggested mechanism to resume treatment without heparin had been to allow resume with minor flag changes to allow the treatment to continue. At this point clearing the alarm may be all that is necessary. Code updated.

DIALIN-DEN-15199-1 26 Apr 2023

This is here is because when they request the configs I set the dictionary to reset mode until the new values have been received from the firmware and then the dictionary is updated with the firmware values. Thanks I moved it to only execute it if the message was received successfully.

HD-DEN-15196-1 26 Apr 2023

Moved comm fault check to be after we are ready to recv bytes.

DIALIN-DEN-15199-1 26 Apr 2023

RESOLVED.

RO-LDT-332-1 24 Apr 2025

Remove Extra line?

RO-LDT-332-1 21 Apr 2025

Add doxygen group. Add function prototypes for init, transition and exec functions.

RO-LDT-332-1 24 Apr 2025

\Sent should be \b Sent

RO-LDT-332-1 24 Apr 2025

Should be pendingStartGenRequest.

RO-LDT-566-2 23 Jul 2025

Add comment for why needed.

HD-DEN-14546-2 27 Apr 2023

Check-in of test run, not intended to be complete. Updated.

RO-LDT-566-2 23 Jul 2025

Remove blank line.

RO-LDT-566-2 23 Jul 2025

Why does this monitor need these mode includes?

HD-DEN-15024-1 27 Apr 2023

Changed to 10 along with the max windowed timer count. DVT-005 was failing with a count of 5-7. It is passing now with max of 10.

HD-DEN-15024-1 26 Apr 2023

This appears to be causing problems 1) at startup and 2) after fast operations (e.g. retract, preload, seek).
For #1, not sure what's happening at startup, but apparently the position reported by FPGA is not stable for a little while after startup.
Probably need to exempt first second (previous 1sec persistence seemed to work fine) after powerup to prevent false alarms.
For #2, I think it just takes a little while for pump to actually come to full stop after pump was running fast.
The syringe pump monitor and controller are running in priority task at 100 Hz, so a count of 5 is only 50 ms. Need to play around with this count to see how much time is needed to come to complete stop and then set count to something north of that time (at 10ms per count) for margin.

DIALIN-DEN-15199-1 26 Apr 2023

Shouldnt this reset be in cmd_reset_all_test_configs()? It should also be executed after a successful message.

HD-DEN-15023-1 01 May 2023

Fixed. Thanks!

HD-DEN-15023-1 01 May 2023

Fixed. Thanks!

HD-DEN-15023-1 01 May 2023

Fixed. Thanks!

HD-DEN-15023-1 01 May 2023

Fixed. Thanks!

HD-DEN-15023-1 01 May 2023

Add blank line between ifs.

HD-DEN-15023-1 01 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15023-1 01 May 2023

Remove extra blank line.

HD-DEN-15023-1 01 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15023-1 01 May 2023

This appears to be in ms. Should at least say in comment.

HD-DEN-15023-1 01 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15023-1 01 May 2023

Should this be looking at >2.5V (instead of pre-tx occlusionDetected flag)?

HD-DEN-15023-1 01 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15024-1 01 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15196-1 24 Apr 2023

It looks like we could get here pretty regularly while we're waiting for command transmit to complete (if statement above) which should not be counted as a comm error unless it's taking too long (timeout).

HD-DEN-15196-1 01 May 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14892-3 03 May 2023

Is #if temporary?

HD-DEN-14262-1 03 May 2023

Done.

HD-DEN-14262-1 03 May 2023

Done.

HD-DEN-14262-1 03 May 2023

Done.

HD-DEN-14262-1 03 May 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14262-1 02 May 2023

Add recircEndTreatmentRequested to header.

HD-DEN-14262-1 03 May 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14262-1 02 May 2023

Add txEndAlarmEndTreatmentRequested to header.

HD-DEN-14262-1 03 May 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14262-1 02 May 2023

Add endTreatmentRequested to header

HD-DEN-14892-3 03 May 2023

Is the merge correct?

HD-DEN-14892-3 03 May 2023

Looks like merge issues not resolved.

HD-DEN-14892-3 03 May 2023

Are these #if temporary?

HD-DEN-15199-1 04 May 2023

Done

HD-DEN-15199-1 04 May 2023

Please see changes.

DG-DEN-15265-1 04 May 2023

Done.

DG-DEN-15265-1 04 May 2023

Should be &result.

DG-DEN-15265-1 04 May 2023

RESOLVED in CODE WALKTHROUGH.