•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13989-2 24 Apr 2023

I think we are regularly setting new targets on the concentrate pumps when we are mixing (trying to keep mix ratio same while RO flow is potentially changing due to control). That would mean the persistence is being cleared all the time while mixing, essentially rendering the alarm disabled. I don't think we should reset here.

DG-DEN-13989-2 24 Apr 2023

Two V&V runs seemed to trigger the pump speed alarm when pump was slowing, then turned off. It seemed possible that the change in pump target speed was occurring while the persistent alarm was on it's way to being triggered.

DG-DEN-13989-2 24 Apr 2023

Magnitude. Error limit for the case when the value is reaching the resolution of the measurement, where the error is specified as +-REL%, or +-MAG, whichever is greater.

HD-DEN-14980-1 24 Apr 2023

This if should be the outermost if (before the if above) so that the else with the s/w fault aligns with it.

HD-DEN-14980-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13989-2 25 Apr 2023

Removed. We'll want to watch for continued pump speed errors occurring on going to zero. There seem to be both RPM resolution and lag errors in the speed measurement, causing problems with the alarm. If problems continue, we should consider increasing the trigger interval, decreasing the clear interval, and/or resetting the alarm when the target is set to zero (or taking a large step).

DIALIN-DEN-15199-1 26 Apr 2023

???

DG-DEN-15199-1 26 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 24 Apr 2023

Still want check for logged in.

DIALIN-DEN-15199-1 26 Apr 2023

Add file header

HD-DEN-16693-1 07 Mar 2024

Done

HD-DEN-16693-2 14 Mar 2024

Let's keep "///" 3 line comment for doxygen generation.

SCRIPTS-DEN-16686-1 08 Mar 2024

keep this and the similar ones.

UI-DEN-16687-1 11 Mar 2024

RESOLVED

HD-DEN-16713-1 12 Mar 2024

Done

DG-DEN-15199-1 26 Apr 2023

Brought the code back.

DG-DEN-15199-1 26 Apr 2023

Done.

HD-DEN-16713-1 12 Mar 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 26 Apr 2023

Done

DG-DEN-15199-1 26 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 26 Apr 2023

Done

TD-LDT-94-3 21 Apr 2025

Done.

DG-DEN-15199-1 26 Apr 2023

Done

DG-DEN-15199-1 26 Apr 2023

Why did we blank title/instructions?

DG-DEN-15199-1 26 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 26 Apr 2023

Acking even if payload length > 0?

DG-DEN-15199-1 26 Apr 2023

RESOLVED in CODE WALKTHROUGH.

TD-LDT-94-3 21 Apr 2025

Yes. Done.

DG-DEN-15199-1 26 Apr 2023

I said fix throughout. Need fix in function below as well.

DG-DEN-15199-1 26 Apr 2023

This is an output.

DG-DEN-15199-1 26 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 26 Apr 2023

Remove "Been" from function name. And add a comment line above explaining what we're doing here.

DG-DEN-15199-1 26 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-15199-1 26 Apr 2023

This will be updated once we move to HD.

HD-DEN-16693-2 14 Mar 2024

Done

DIALIN-DEN-15199-1 26 Apr 2023

The file heater will be added automatically in upon the staging build.

HD-DEN-16693-2 14 Mar 2024

I thought we weren't going to do this anymore?

HD-DEN-16773-1 18 Mar 2024

Can we remove the AIR_PUMP_OPERATION_TIMEOUT Macro?

DIALIN-DEN-15199-1 26 Apr 2023

The file header will be added upon the staging build.

DD-LDT-319-1 21 Apr 2025

Done.

DG-DEN-15199-1 26 Apr 2023

Done

DIALIN-DEN-15199-1 26 Apr 2023

Add file header

HD-DEN-16773-1 19 Mar 2024

RESOLVED in CODE WALKTHROUGH.

DIALIN-DEN-15199-1 26 Apr 2023

RESOLVED.

TD-LDT-94-3 21 Apr 2025

update as required (few functions Inputs and outputs are either empty or none, please fill in as applicable)

DIALIN-DEN-15199-1 26 Apr 2023

RESOLVED.

UI-DEN-16777-1 19 Mar 2024

Done

DIALIN-DEN-15199-1 26 Apr 2023

RESOLVED.

DG-DEN-15199-1 26 Apr 2023

Checking for isTestingActivated should be done in sendTestConfigStatusToDialin function (not here). Fix throughout new handlers.

DD-LDT-319-1 22 Apr 2025

Done.