•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14980-1 21 Apr 2023

Not needed. Remove.

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

We need new alarm . That should be included in SRS right ? or shall i use SET_ALARM_WITH_2_U32_DATA( ALARM_ID_TD_SOFTWARE_FAULT) ?

UI-DEN-16687-1 07 Mar 2024

Done

UI-DEN-17260-1 03 Apr 2025

Done

UI-DEN-16687-1 07 Mar 2024

Done

HD-DEN-16693-1 07 Mar 2024

Done

DD-LDT-319-1 21 Apr 2025

Done. Somehow its aligned in CCS editor.

SCRIPTS-DEN-16686-1 08 Mar 2024

please don't use # leading lines.
it fills the code with unnecessary comment line.s

TD-LDT-94-3 22 Apr 2025

Done.

SCRIPTS-DEN-16686-1 08 Mar 2024

these comments are redundant and are Linux commands comments.
please remove this and similar ones.

DD-LDT-319-1 21 Apr 2025

Align comment.

HD-DEN-16693-1 08 Mar 2024

RESOLVED IN CODE WALKTHGROUGH

UI-DEN-16687-1 07 Mar 2024

move this to the Views - Settings for headers.

DIALIN-DEN-16693-2 11 Mar 2024

Good catch. Thanks. I added the module.

DIALIN-DEN-16693-2 11 Mar 2024

RESOLVED.

LEAHI-APPLICATION-LDT-1516-1 25 Jul 2025

as discussed after the meeting yesterday this was not the most practical way so updated as we discussed to not change the main dialogs and adjsut the stack dialogs

UI-DEN-16777-1 19 Mar 2024

please align the all the ).arg(

HD-DENBUG-298-1 04 Apr 2025

Bad practice to have two calls to same function here. Possible that 2nd call will return different result.
Should call function once to assign value to a local var prior to if statement and then reference the local var in the if statement.

HD-DENBUG-298-1 04 Apr 2025

RESOLVED in CODE WALKTHROUGH.

TD-LDT-802-1 28 Jul 2025

Done

TD-LDT-94-3 21 Apr 2025

Done.

TD-LDT-94-3 21 Apr 2025

Removed. Not necessary.

TD-LDT-94-3 21 Apr 2025

Fixed.

DD-LDT-319-1 21 Apr 2025

Done.

RO-LDT-332-1 21 Apr 2025

Add init for pre gen.

RO-LDT-332-1 21 Apr 2025

Add case for pre gen.

RO-LDT-332-1 21 Apr 2025

Alphabetize.

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks. Functions in their respective mode files

RO-LDT-332-1 24 Apr 2025

Remove blank line 93 and 108.

DG-DENBUG-318-1 20 May 2025

Done

LEAHI-APPLICATION-LDT-1042-1 24 Jul 2025

RESOLVED

DG-DENBUG-318-1 21 May 2025

Why are we keeping these in the broadcast?

DG-DENBUG-318-1 27 May 2025

RESOLVED in CODE WALKTHROUGH.

LEAHI-DIALIN-LDT-566-1 23 May 2025

Not air pump. Change to ejector.

LEAHI-APPLICATION-LDT-1042-1 22 Jul 2025

Added button status and notification messages

RO-LDT-566-2 23 Jul 2025

Need function headers.

RO-LDT-566-2 23 Jul 2025

Why does this monitor need these mode includes?

LEAHI-APPLICATION-LDT-1042-1 22 Jul 2025

Generally, please update everywhere the following:

  • After line (35) Device Settings Screen, the line of TCH (36) should be better specified as Export Log Menu, rather than Button, to clarify.
LEAHI-APPLICATION-LDT-1730-1 24 Jul 2025

RESOLVED

TD-LDT-802-1 28 Jul 2025

Added an abort ejector request.

LEAHI-APPLICATION-LDT-1516-1 24 Jul 2025

remove visible key

RO-LDT-566-2 23 Jul 2025

Add blank line before return.

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

Great catch,
Generally, please do NOT use:

$ git add .

for your commits, please review your changes prior to committing.

RO-LDT-566-2 30 Jul 2025

Removed. It was there before as we had a START_STATE and that would allow the transition from start to full or fill.

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

Remove line since effective code is commented out.

RO-LDT-566-2 30 Jul 2025

function have been removed as we no longer need it

TD-LDT-736-1 28 Jul 2025

just 0.0F would work?

TD-LDT-736-1 28 Jul 2025

Please add param.

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!