•  

Comment Results

Review Name Created Custom Fields Content
HD-DENBUG-298-1 03 Apr 2025

Are these permanent?

HD-DENBUG-298-1 04 Apr 2025

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1 04 Apr 2025

Done

TD-LDT-94-3 21 Apr 2025

Just ultrafiltration (remove saline)?

HD-DEN-14980-1 21 Apr 2023

Alarm checks re-ordered.

HD-DEN-14980-1 21 Apr 2023

This should probably be up top before the outer if (i.e. checked every time) as there is no dependency on the given alarm ID.

DG-DEN-15199-1 21 Apr 2023

Change "release" to "test".

DG-DEN-15199-1 21 Apr 2023

Yes, s/w fault (for invalid config). Ignore command for not logged in.

DG-DEN-15199-1 21 Apr 2023

Yes, s/w fault (for invalid config). Ignore command for not logged in.

DG-DEN-15199-1 21 Apr 2023

Note in brief that function will return FALSE if Dialin not logged in.

TD-LDT-94-3 21 Apr 2025

min:50?

LEAHI-APPLICATION-LDT-1042-1 22 Jul 2025

Updated

DD-LDT-319-1 21 Apr 2025

Add a message sent detail.

DD-LDT-319-1 22 Apr 2025

Want Pre Gen mode state machine to handle the mode change - so request function should set a flag that the state machine will act on in next pass.

TD-LDT-94-3 21 Apr 2025

Fixed.

TD-LDT-94-3 21 Apr 2025

Fixed.

TD-LDT-94-3 21 Apr 2025

you may need to remove these variables:" disinfectCancelReqID, homingInitiated"?

RO-LDT-332-1 21 Apr 2025

Needs init, transition, and exec functions at a minimum. Needs to handle DD msg to transition to gen water mode too.

RO-LDT-332-1 21 Apr 2025

Alphabetize.

RO-LDT-332-1 21 Apr 2025

Add a #define for this unit (i.e. #define _ALARM_MGMT_RO_C_)

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

RO-LDT-332-1 24 Apr 2025

Fixed. Thanks!

RO-LDT-332-1 24 Apr 2025

preGenWState is not an output.

RO-LDT-332-1 24 Apr 2025

standbyState should be preGenWState.

LEAHI-APPLICATION-LDT-1042-1 22 Jul 2025

Updated

RO-LDT-566-2 23 Jul 2025

Should Temperature monitor be publishing these temperatures?

RO-LDT-566-2 01 Aug 2025

agreed. its been removed

LEAHI-APPLICATION-LDT-1042-1 24 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1042-1 22 Jul 2025

same as the following comment:
http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-1042-1CFR-69341

LEAHI-APPLICATION-LDT-1516-1 25 Jul 2025

removed and updated to create the all the menu models inside of MainMenu.qml and set the models when needed

TD-LDT-802-1 27 Jul 2025

Do we need a way to abort an ejector operation if it is in progress when fault triggered?

DD-LDT-1473-1 28 Jul 2025

With the updated FPGA logic for continuous flow rate, doesn't need this variable anymore.

LEAHI-APPLICATION-LDT-1516-1 28 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1516-1 28 Jul 2025

resolved.

LEAHI-APPLICATION-LDT-1516-1 29 Jul 2025

this still does the affect. I believe if you leave the property animation empty it will animate all changes of whatever Behavior is on. Refer https://doc.qt.io/archives/qt-5.15/qml-qtquick-propertyanimation.html

TD-LDT-736-1 29 Jul 2025

You're right. Old comment from Denali. Fixed.

RO-LDT-566-2 30 Jul 2025

fixed in renamed file. thanks.

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks!

RO-LDT-566-2 30 Jul 2025

fixed. thanks

RO-LDT-566-2 30 Jul 2025

fixed. thanks

RO-LDT-566-2 22 Jul 2025

Shouldn't be override. Change Dialin from "override" to "set" cmd.

RO-LDT-566-2 23 Jul 2025

No output.

TD-LDT-802-1 01 Aug 2025

Done

RO-LDT-566-2 23 Jul 2025

Add alarm(s) triggered to header.

RO-LDT-566-2 24 Jul 2025

genPermeateState is an input and output.

RO-LDT-566-2 01 Aug 2025

Remove extra blank line.

LEAHI-APPLICATION-LDT-1788-1 01 Aug 2025

updated

DD-LEAH-230-1 02 Apr 2025

Done.