•  

Comment Results

Review Name Created Custom Fields Content
SCRIPTS-DEN-16686-1 08 Mar 2024

Done

SCRIPTS-DEN-16686-1 08 Mar 2024

Done

UI-DEN-16687-1 07 Mar 2024

please update the document for the payload.

HD-DENBUG-298-1 28 Mar 2025

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16773-1 19 Mar 2024

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-1209-1 21 Jul 2025

RESOLVED.

DD-LDT-880-1 21 Jul 2025

Done.

HD-DENBUG-298-1 28 Mar 2025

For other confirmations, an executive (e.g. alarm mgmt monitor or standby mode exec) is responsible for checking confirmation status and we don't call specific handlers from here. Why can't we follow that design pattern for this confirmation?

DG-DENBUG-307-1 02 Apr 2025

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-1516-1 21 Jul 2025

Can it be LockDialog Dialog component?

LEAHI-APPLICATION-LDT-907-1 07 Jul 2025

Instead of having this extra Rect. Can we customize the parent Rect in CloseButton and make the parent Rect larger than the Image component inside and color the border to achieve the same desired look?

LEAHI-APPLICATION-LDT-1516-1 22 Jul 2025

Yes I created a LockDIalog componenet

RO-LDT-566-2 22 Jul 2025

I don't see that this flag is ever set to TRUE. Where is this needed?

LEAHI-APPLICATION-LDT-1209-1 15 Jul 2025

Please make the _title, _value width as properties with default values of what you set here.

LEAHI-APPLICATION-LDT-1516-1 22 Jul 2025

updated

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

Started the ID changes for DD. I prefer changing all my needed ID's and slowly creating to their M&V.

RO-LDT-566-2 23 Jul 2025

Why is s/w fault commented out?

RO-LDT-566-2 22 Jul 2025

FluidPump.h is included in BoostPump.h, so not needed here.

LEAHI-APPLICATION-LDT-907-1 21 Jul 2025

Please align the Data words.

RO-LDT-566-2 23 Jul 2025

If nothing to do in these modes, add a comment before break indicating we're doing nothing on purpose because nothing is required.
Also, consider grouping these "do nothing" modes together (no blank lines between, 1 break at end, shared function (which is nothing)).

RO-LDT-566-2 23 Jul 2025

Why not just do monitoring function here in this function instead of calling another? I don't see what value this function is adding.

RO-LDT-566-2 22 Jul 2025

Put first part of condition in () too.

RO-LDT-566-2 23 Jul 2025

Isn't there a common override function you can call to fetch the value?

RO-LDT-566-2 23 Jul 2025

Remove blank line.

RO-LDT-1809-3 26 Aug 2025

Removed return and replaced with skip flag

RO-LDT-1809-3 26 Aug 2025

Added comment line

RO-LDT-1809-3 26 Aug 2025

Add @param for new param.

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-926-1 28 Aug 2025

addressed

DD-LDT-2030-1 29 Aug 2025

Done

DD-LDT-2030-1 29 Aug 2025

It was commented for testing. It is uncommented.

DD-LDT-2030-1 29 Aug 2025

Done

HD-DEN-16672-2 05 Mar 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 21 Apr 2023

Done

HD-DEN-14980-1 21 Apr 2023

Comment doesn't seem to match how timer is used (to decide whether to block alarm trigger).

DG-DEN-15199-1 21 Apr 2023

memset wants a byte. Just say 0 instead of using KEY #define.
Also, TEST_CONFIG_T is an enum, so size is probably 1 and so this probably won't initialize whole array.

DG-DEN-15199-1 21 Apr 2023

Add blank line between banner and #define.

DD-LEAH-230-1 02 Apr 2025

Done.

UI-DEN-16687-1 07 Mar 2024

Correct.

DD-LEAH-230-2 02 Apr 2025

Done.

DD-LEAH-230-1 31 Mar 2025

Remove this constant if not needed.

HD-DEN-16693-1 07 Mar 2024

Done

DD-LEAH-230-1 31 Mar 2025

This function is pretty long. Can we make this FF calculation a separate function to call from here?

HD-DEN-16693-1 07 Mar 2024

RESOLVED in CODE WALKTHROUGH.

SCRIPTS-DEN-16686-1 08 Mar 2024

Done

UI-DEN-16687-1 07 Mar 2024

why did you call the parametersText every time?
you only need to call it when the values are updated fully?

UI-DEN-16687-1 07 Mar 2024

I assume this will automatically get updated on Bamboo, for both cpp and h right?
If not update it.

UI-DEN-16687-1 11 Mar 2024

RESOLVED

TD-LDT-736-1 17 Jul 2025

Restore bulk of this function for now.

UI-DEN-16687-1 11 Mar 2024

RESOLVED