•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-1209-1 21 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1209-1 21 Jul 2025

RESOLVED.

DD-LDT-880-1 18 Jul 2025

If timer set is initialized to FALSE, shouldn't the timer be initialized to zero?

RO-LDT-566-2 22 Jul 2025

Remove extra blank line.

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

done!

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

done!

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

RESOLVED

RO-LDT-566-2 23 Jul 2025

Add comment for why we need this.

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

RESOLVED

RO-LDT-566-2 23 Jul 2025

Update inputs and outputs.

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

RESOLVED

RO-LDT-566-2 23 Jul 2025

Remove extra blank line.

RO-LDT-566-2 23 Jul 2025

Add comments to right.

RO-LDT-566-2 23 Jul 2025

Blank line before default.

RO-LDT-566-2 23 Jul 2025

What is value of this function? Why not bring in functionality of called function?

RO-LDT-566-2 23 Jul 2025

Add isFlushComplete to input.

RO-LDT-566-2 23 Jul 2025

FPInitAndPOSTMode

RO-LDT-566-2 23 Jul 2025

Need function headers.

RO-LDT-566-2 23 Jul 2025

When we merge with DD for beta, will need unique unit names. Should we change to FPOperationModes?

RO-LDT-566-2 23 Jul 2025

Pre gen and gen modes appear to be doing the exact same thing. And defeatured modes are only different in that they are looking at M4 instead of P10.
Consider handling monitoring differently. Instead of monitor being aware of mode and acting accordingly, should mode call a signal function in the monitor to configure the monitor appropriately for that mode? With this approach, seems like a lot of these functions could be merged into 1 with a couple "if" conditions checking current monitor configuration. I also think this approach is a better design pattern because monitor does not need to concern itself with higher level details (e.g. current mode) - better to have higher level units (modes, states) telling lower level units (drivers, monitors, controllers) what's appropriate.

RO-LDT-566-2 23 Jul 2025

Don't we need at least 2 states (energized and de-energized) per SRS?

RO-LDT-566-2 24 Jul 2025

Align with others.

RO-LDT-566-2 23 Jul 2025

Add extra blank line before test support banner.

RO-LDT-566-2 23 Jul 2025

Remove extra blank line.

RO-LDT-566-2 24 Jul 2025

Add param.

RO-LDT-566-2 24 Jul 2025

Add comments to right.

RO-LDT-566-2 23 Jul 2025

Oddly worded. I would say "TRUE if concentrate flush is complete, FALSE if not."

RO-LDT-566-2 23 Jul 2025

\Sent should be \b Sent.

RO-LDT-566-2 22 Jul 2025

Add comment to right if keeping this variable. Otherwise remove variable.

RO-LDT-566-2 22 Jul 2025

Put first part of condition in () too.

RO-LDT-566-2 23 Jul 2025

Change to "isFPDefeatured"?

RO-LDT-566-2 23 Jul 2025

Remove blank line.

RO-LDT-566-2 23 Jul 2025

Remove extra blank line.

RO-LDT-1928-3 27 Aug 2025

Pushed the commit

RO-LDT-1809-3 27 Aug 2025

Changed

LEAHI-APPLICATION-LDT-2160-1 27 Aug 2025

RESOLVED

RO-LDT-1242-1 29 Aug 2025

Add comment to right.

LEAHI-SW-LDT-926-1 28 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-2071-1 29 Aug 2025

RESOLVED.

UI-DEN-16687-1 07 Mar 2024

I thought it is needed. Removed them.

DD-LEAH-230-1 02 Apr 2025

Done.

SCRIPTS-DEN-16686-1 08 Mar 2024

please return the comments back in this script.
these two lines are examples of actual run.
The rest is commented by group.

SCRIPTS-DEN-16686-1 08 Mar 2024

Done

TD-LDT-94-3 21 Apr 2025

Move below to maintain alphabetical order?

HD-DEN-16773-1 19 Mar 2024

Done

DD-LEAH-230-1 03 Apr 2025

Done.

DG-DEN-15199-1 21 Apr 2023

This function is a Dialin command so it will not even be called if Dialin is not logged in. Did you want to check this again in this function?

UI-DEN-17260-1 03 Apr 2025

RESSOLVED

DG-DEN-15199-1 21 Apr 2023

Done