It's 1 line of code either way. Just on top or below in an else. Vectorcast will see as a branch you need to test either way. If you put it in an else, the processor does less work and I think it's a lot easier to read.
OperationModes.c init function is only at power up. This call to init treatment mode is intended to re-init treatment mode before each treatment starts.
Add a condition that we not have a Dialin user logged into FP. If FP Dialin tester is logged in, we don't want to enforce legal mode transitions because we want to allow the set mode command to take us anywhere from any mode.
I think the proxy cmd to start pre gen should be sufficient to support this. We do not typically allow Dialin to set internal variables that are not sensor readings. Consider removing this override (and any others like it).
Michael, are you sure you want to organize the proxies this way (i.e. putting TD proxy commands in the TD class instead of the DD class)? Downside for me is that, as a tester, I have to create a TD class to get TD proxy functionality when I may only want to work with DD class to test the DD. What is the upside to doing it this way?
This is great, Please add the status of buttons, such as the eject and export buttons, which are disabled during export. Additionally, note the notification messages during the process.
'maximum' is also referenced in: SDDs/Main_Treatment/FinalDiagram.dot sources/gui/qml/pages/treatment/TreatmentUltrafiltrationItem.qml sources/gui/qml/pages/treatment/TreatmentStack.qml sources/gui/qml/pages/pretreatment/connection/PreTreatmentConnectionStack.qml
You are running release
CR4.8.14
FE4.8.14
(20240111091859 2024-01-11 09:20),
please report your release number when reporting bugs.
