•  

Comment Results

Review Name Created Custom Fields Content
RO-LDT-566-2 23 Jul 2025

Should sensor temperatures be read in this driver (since coming from this sensor)? Like PressureSensor.c does it.

DD-LDT-1473-1 27 Jul 2025

It's "filtration", not "filteration". Misspelled throughout.

TD-LDT-802-1 28 Jul 2025

I brought the code in but they are not called.

RO-LDT-566-2 23 Jul 2025

I would say something like "the concentrate flush timeout period in ms"

RO-LDT-566-2 23 Jul 2025

Add comment before break to indicate we are doing nothing on purpose.
Consider grouping modes that do nothing (no blank lines between, 1 break at end of group, 1 comment).

HD-DEN-14980-1 21 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1 07 Mar 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 21 Apr 2023

This function will not even be called if Dialin is not logged in. Did you want to check it here too?

UI-DEN-16687-1 11 Mar 2024

Done

DG-DEN-15199-1 21 Apr 2023

I removed the memset macro.

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

related comment.

TBDL: Let's discuss more later.

DG-DEN-15199-1 21 Apr 2023

Done

HD-DEN-16693-2 14 Mar 2024

This is in a different function. I can remove.

DG-DEN-15199-1 21 Apr 2023

Done

DG-DEN-15199-1 21 Apr 2023

Correct. This common code in between the two stacks. I can separate them using #ifndef.

DG-DEN-15199-1 21 Apr 2023

Done

HD-DEN-16773-1 18 Mar 2024

This should probably be in an else below.

DG-DEN-15199-1 24 Apr 2023

Done.

HD-DEN-16773-1 19 Mar 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 24 Apr 2023

Done.

DD-LDT-319-1 21 Apr 2025

preGenDialysateState is an input.

HD-DEN-14980-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14980-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 24 Apr 2023

Yes, as this function could be called from somewhere other than message handler.
RESOLVED in CODE WALKTHROUGH.

DD-LDT-319-1 21 Apr 2025

Done.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DD-LDT-319-1 21 Apr 2025

preGenDialysateState is an input.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

RO-LDT-332-1 21 Apr 2025

Add case for pre gen.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 24 Apr 2023

Not a Dialin command. Called by opmodes in firmware.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15199-1 21 Apr 2023

We want test configs be active only if explicitly enabled. Safest condition would be to say ( TRUE == getTest.... ).
Make this change everywhere getTestConfigStatus function is used.

DG-DEN-15199-1 24 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13989-2 24 Apr 2023

Does target speed being less than 3.0 mean the target speed is 0.0? I understand that 3.0 mL/min is very close to 0.0 mL/min for this pump but I think we should be less than NEARLY_ZERO.

HD-DEN-14546-2 24 Apr 2023

What's driving this change? Why no rinseback for empty sryinge alarm?

HD-DEN-14546-3 24 Apr 2023

Why accept Heparin resume when our syringe is empty?

DG-DEN-13989-2 24 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14980-1 24 Apr 2023

Thank you - corrected.

DG-DEN-15199-1 24 Apr 2023

Done

DG-DEN-15199-1 24 Apr 2023

Done

HD-DEN-14980-1 24 Apr 2023

Was expecting you to move if, not else.
Doesn't make sense to check alarm (line 359..361) before validating alarm (line 364).

DG-DEN-13989-2 24 Apr 2023

What does MAG stand for?

DG-DEN-13989-2 24 Apr 2023

Why are we resetting the persistent alarms here?

HD-DEN-14980-1 24 Apr 2023

Done.