This is to be identical to the enum in firmware but in a Dialin enum we cannot have two enums with one number assigned to them since the Dialin enum is an ordered dictionary so we cannot have multiple keys with one number. I removed the commented enum.
Added space. I modified slightly, Since this is called outside of the interrupt where the sci2FEOEError is being set I believe it should get the value and only reset it if was TRUE.
Split will have a value in index 0 as long as the subprocess call is successful. If the subprocess is not successful, the exception will be caught in the message handler and CS will report an error.
The exception handling was redundant since the message handler will catch it in ui_cs_request_handler.py and log it as CS_LOG_ROTATION_ERROR.
Added check for split() length and if it fails, it'll write to the gutils logger that the subprocess call failed in the chance that subprocess.check_output succeeds but doesn't not contain any data.
a catchall exception is not a good idea, please separate the split() and [0], and first check the index exists, the use it. it is good to keep it if the process fails, but incorrect/unexpected result is not being caught.
You are running release
CR4.8.14
FE4.8.14
(20240111091859 2024-01-11 09:20),
please report your release number when reporting bugs.
