I had done it but sorry I did not save it.
should be 1,000
Done
Why is message still a param - appears to be unused and unnecessary.
RESOLVED in CODE WALKTHROUGH.
Done.
Should be float (0.0).
RESOLVED.
float ('f').
filtered occlusion pressure s/b/ a float.
Use F32 macro since filtered pressure will be float.
Can stay U32.
RESOLVED
3 - move this out of if and do it regardless of accept or reject.
2 - remove this line and rely on the mFirmwareValue
Can we get by with just 1 msg? Add doxygen comments.
Fixed
RESOLVED in CODE WALKTHROUGH
Why isn't this just an else? And if else should be swapped so normal action (alarm) comes first with if and the else should be the exception (else).
incorrectly pushed and opened. this cr was already complete and done. the diff will be reviewed on the http://devapps.diality.us:8060/cru/UI-DEN-16657-15
Does this need to be public?
Removed. Replaced fpgaReadByteSize with sizeof( FPGA_SENSORS_T ) in the two statements that it was being used.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
