•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-1616-1 18 Sep 2025

My bad,
Thanks for the clarification.
Misread the views.
RESOLVED.

HD-DEN-16713-1 12 Mar 2024

TREAT_PARAMS_PROPERTIES[] is an input for all of these functions.

HD-DEN-16693-2 14 Mar 2024

Done

HD-DEN-16693-2 14 Mar 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-2 14 Mar 2024

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-16773-1 18 Mar 2024

Done

DD-LDT-880-2 21 Jul 2025

Done.

HD-DEN-16773-1 18 Mar 2024

disinfect is misspelled.

DD-LDT-880-1 18 Jul 2025

Recommend 0.0F if control interval is short (like 3 sec) so we don't introduce an initial error to PI controller.

DD-LDT-880-1 18 Jul 2025

If you use timer functions to manage sample interval, it is possible to have 10ms jitter.
Priority task is initiated every 10ms very accurately, but when code is executed within any given priority task interval can vary with position of the code in the task sequence and varying amount of time taken to complete each part of the task sequence from one interval to the next. So it is possible that sometimes you could have the ms timer saying something like 59ms when you would expect 60ms (because it's been 6 times through the 10ms task). In cases like this, you would wait for the next task (so 10ms later).
I think it's safer to use a task interval counter and multiplying the counter by the task interval (10ms).

LEAHI-APPLICATION-LDT-1209-1 21 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

done!

RO-LDT-566-2 23 Jul 2025

Why not just remove these? And, in fact, why do we even have this driver anymore? The conductivity sensor driver has P10 and P19 covered, pressuresensor has others covered and fpgaFP will have PCB temps covered I think and so what's left for this driver to read?

LEAHI-APPLICATION-LDT-907-1 21 Jul 2025

Why did these change?

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-907-1 22 Jul 2025

RESOLVED

RO-LDT-566-2 23 Jul 2025

Remove blank lines.

RO-LDT-566-2 23 Jul 2025

\Sent should be \b Sent.

RO-LDT-566-2 21 Jul 2025

Add comments to right.

RO-LDT-566-2 23 Jul 2025

Remove blank line.

RO-LDT-566-2 23 Jul 2025

Remove blank line.

RO-LDT-566-2 23 Jul 2025

Is it ok if this function gets called when we're not paused in concentrate flush? Should we s/w fault? Should we inform caller (return FALSE)?

RO-LDT-566-2 23 Jul 2025

No output.

RO-LDT-566-2 23 Jul 2025

Remove blank line.

RO-LDT-566-2 23 Jul 2025

Add blank line before return.

RO-LDT-566-2 23 Jul 2025

No output.

RO-LDT-566-2 23 Jul 2025

Reword per same comment in other units.

LEAHI-APPLICATION-LDT-1730-1 24 Jul 2025

regenerated this file so it should be updated

LEAHI-APPLICATION-LDT-1516-1 21 Jul 2025

Please use * -1, to make it clear.

LEAHI-APPLICATION-LDT-1516-1 24 Jul 2025

please update to "* -1"

RO-LDT-566-2 22 Jul 2025

Put first part of condition in () too.

RO-LDT-566-2 22 Jul 2025

Remove extra blank line.

RO-LDT-566-2 23 Jul 2025

Add comment for why we need this.

RO-LDT-566-2 23 Jul 2025

Add blank line before return.

RO-LDT-566-2 23 Jul 2025

Remove extra blank line.

DG-DEN-15199-1 21 Apr 2023

Also, Dialin must be logged in to accept a test config command.

DG-DENBUG-307-1 02 Apr 2025

I used fabs so all are positive when monitoring is started.

UI-DEN-16687-1 07 Mar 2024

Done

HD-DEN-16693-1 07 Mar 2024

Do we need to add check for minimum treatment duration?

DD-LEAH-230-1 02 Apr 2025

Done.

SCRIPTS-DEN-16686-1 08 Mar 2024

used 2 empty line space in this script.
so please return them back.

SCRIPTS-DEN-16686-1 08 Mar 2024

Done

UI-DEN-16687-1 07 Mar 2024

please correct the numbering.

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

Alarm should be handled inside of setAirPumpState().

UI-DEN-16687-1 11 Mar 2024

commented on the new location.
RESOLVED

LEAHI-APPLICATION-LDT-907-1 17 Jul 2025

I see this component also being used in treatment adjustments (which do not have the extra rectangle) so best to discuss if we may make all the same or leave

HD-DEN-16773-1 19 Mar 2024

Done

RO-LDT-566-2 22 Jul 2025

Where did these slope and intercept definitions get moved to?

HD-DEN-16773-1 19 Mar 2024

I thought about having an else below but this way we write less code. I have done similar in the past.

DD-LDT-880-1 21 Jul 2025

Done.