RESOLVED
move this to the Views - Settings , cpp
Done
this is the model section. Please move to view section.
FF enabled should be TRUE/FALSE (not 1/0).
lets keep "///" comment for doxygen generation.
Indicate we are signaling a change in Qd here.
RESOLVED IN CODE WALKTHROUGH
Do we still need test timing? Can we remove?
Add comments to right.
Redefined delta temperature to 0.5F to go over the target temperature (i.e., Target Temp + 0.5) to compensate with reduced Feedforward control. We will adjust this as needed based on the testing.
I took alarm 98 and 99 in my TD branch.
Please let's keep this as is for now. Thanks.
RESOLVED.
Please add the message ID as well, from now on. Thanks.
Fixed.
RESOLVED. closing.
What update is required?
RESOLVED in CODE WALKTHROUGH.
Update header, setUFVolStatus
Variables in lines 153 to 165 should be in header... unless pre-treatment mode module initialized covers them.
For init functions, I typically do not itemize variables (list too long) and just say initialize module.
I moved it to the end of the table
Why remove?
Yes we do not support Beta in release.
This is in the Off state in which RPM being too high occurs when the RPM is greater than the minimum RPM which is 300.
Add to enum above as well.
Please check the code again.
request will remain if inlet alarms active. is that what we want?
Looks like we will not read ADC channels at all if release build.
Needs default or just do if/else.
Yes, fault.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
