•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

renamed to LabelUnitContainer

DG-DEN-15016-1 30 Mar 2023

I think it's better to end the if not POST body after the retries decrement (so don't use up retry during post, but still resend msg).

DG-DEN-15016-1 31 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1 04 Mar 2024

Done

HD-DEN-15016-1 31 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15016-1 31 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 31 Mar 2023

Corrected

DG-DEN-14646-1 31 Mar 2023

Corrected

DG-DEN-14646-1 31 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14646-1 31 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14646-1 31 Mar 2023

Extra space before the last paren.

DG-DEN-14999-3 07 Apr 2023

This section will be automatically created.

UI-DEN-15037-2 03 Apr 2023

Will address this while implementing the CyberSecurity features.

UI-DEN-15037-2 03 Apr 2023

Is this fix needed now or can it wait?

UI-DEN-15037-2 03 Apr 2023

RESOLVED.

DG-DEN-14999-3 07 Apr 2023

Removed 2nd comment.

UI-DEN-16687-1 11 Mar 2024

commented on the new location.
RESOLVED

UI-DEN-16687-1 11 Mar 2024

Done

UI-DEN-15037-3 04 Apr 2023

Thanks for the comment,
Looks tricky to me too.
But worked fine for me now.
Will keep track of its behavior.

UI-DEN-15037-3 04 Apr 2023

Thank you for pointing that out.
The message view was our of sync as well which has been fixed.

UI-DEN-15037-3 04 Apr 2023

RESOLVED IN CODE WALKTHROUGH.

UI-DEN-15037-3 04 Apr 2023

These values are U32 from FW, do we need to add the toFixed(2)?

UI-DEN-15037-3 04 Apr 2023

RESOLVED

UI-DEN-15037-3 04 Apr 2023

This will give you undesired results. I have done this before and it will end up showing us the intermediate values.

HD-DEN-14830-2 07 Apr 2023

Fixed. Thanks!

HD-DEN-15095-1 10 Apr 2023

I am confused. Copying the properties from the SRSHD document, 1/26/2023
SRSHD 919 lists:

Alarm: ALARM_ID_HD_VENOUS_BUBBLE_DETECTED
ID: 128
Priority: HIGH
HD Fault: No
DG Fault: No
Stop: Yes
Clear Immediate: No
Non-Recoverable: No
No Resume / No Rinseback / No End Treatment: No, No, No
No Blood Recirculate: Yes
No Dialysate Recirculate: No
Clear Top Only: No

-----------------------------
This table makes it appear that No Resume / No Rinseback / No End Treatment and clear immediate should all be FALSE. Is there an error in the SRS tables?

HD-DEN-14999-3 07 Apr 2023

where?

HD-DEN-14999-3 07 Apr 2023

Has 0 persistence on trigger. I'll remove.

HD-DEN-14999-3 07 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14999-3 05 Apr 2023

Interested in return value?

HD-DEN-14830-2 07 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15095-1 10 Apr 2023

I resolved the code as you wrote above, per our conversation.

HD-DEN-14999-3 07 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14999-3 05 Apr 2023

Isn't the ALARM_ID_HD_AC_POWE_LOST already cleared?

HD-DEN-14830-2 07 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14830-2 07 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14830-2 05 Apr 2023

Comment alignment.

DG-DEN-14999-3 05 Apr 2023

Alignment

DG-DEN-14999-3 07 Apr 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14999-3 07 Apr 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14999-3 07 Apr 2023

A single comment marker (c++ style), aligned with the other comments in the block would be a little more readable.

HD-DEN-15095-1 10 Apr 2023

Blaine very recently changed alarm table (and so we changed code) to make it an HD fault. I guess SRS was not updated.
Blaine has agreed to change these alarms as I've noted above. He needs to add PRS requirements and then update SRS to match.

HD-DEN-15095-1 11 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15095-1 10 Apr 2023

Agree that fault property should be FALSE. Clear immediate should remain TRUE. No clear should be FALSE. No resume and no rinseback should be TRUE (we do not think user can recover from this alarm). But no end treatment property should be FALSE (we do want user to be able to go through post-tx process). No blood recirc should be TRUE (we do not want bubble to go to patient), but no dialysate recirc can be FALSE.

HD-DEN-15049-1 12 Apr 2023

Comment is identical to the DG implementation.

HD-DEN-15105-1 12 Apr 2023

Updated.

DG-DEN-13989-2 12 Apr 2023

Thank you, done.

DG-DEN-13989-2 12 Apr 2023

Thank you, done.

DG-DEN-13989-2 12 Apr 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13989-2 11 Apr 2023

0.0F