•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

removed from existance

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

ReadCount and ErrorCount support from FPGA has been removed

DIALIN-DEN-15014-1 28 Mar 2023

Done

DIALIN-DEN-15014-1 29 Mar 2023

RESOLVED.

DIALIN-DEN-15014-1 29 Mar 2023

RESOLVED.

DIALIN-DEN-15014-1 29 Mar 2023

RESOLVED.

DG-DEN-14646-1 29 Mar 2023

Corrected

HD-DEN-14860-1 29 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14860-1 29 Mar 2023

Updated all headers.

UI-DEN-14936-1 30 Mar 2023

RESOLVED.

DG-DEN-14646-1 20 Mar 2023

Comment (and name) do not seem to fit anymore. No longer number of times or a count. Now a max time.

UI-DEN-14937-5 29 Mar 2023

FIXMEs in /sources/view/settings/VSettings.cpp will be addressed in future revision.

UI-DEN-14936-1 30 Mar 2023

Not clear what you want me to do here?

UI-DEN-14936-1 30 Mar 2023

Great catch,
Thank a lot Sean for catching that.
It is fixed.

UI-DEN-14936-1 30 Mar 2023

Fixed too.

HD-DEN-14999-2 30 Mar 2023

Fixed.

HD-DEN-14999-2 30 Mar 2023

Warning (13 min) removed since no longer alarming at 15 min.

HD-DEN-14999-2 30 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14999-2 30 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14999-2 29 Mar 2023

Add timeOfLastUICheckin and uiDidCommunicate.

DG-DEN-14646-1 30 Mar 2023

I don't see it, but resolving anyway.
RESOLVED in CODE WALKTHROUGH.

HD-DEN-14999-2 30 Mar 2023

I don't know. I believe check in msg should have no payload, but it usually does have a u32 of unknown purpose. I have found that the very first check-in after power up has no payload according to candump and this was causing alarm 46. Until UI sorts this out, I am not going to check payload.

HD-DEN-14999-2 30 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

HD-DEN-14999-2 30 Mar 2023

What is the other flavor of UI check in message. If it is a different size, shouldn't it be its own separate message?

UI-DEN-14936-1 30 Mar 2023

Your comment has ???. Trying to help.

UI-DEN-14936-1 29 Mar 2023

Same ordering should apply here (even if order doesn't matter - prefer to match structure of message payload).

UI-DEN-14936-1 30 Mar 2023

RESOLVED.

UI-DEN-14936-1 29 Mar 2023

I think the raw order should be cpi, cpo, cd1, cd2 (reverse of what's here). Same order issue with status below.

UI-DEN-14936-1 30 Mar 2023

RESOLVED.

UI-DEN-14936-1 30 Mar 2023

Thanks,
Will update my comment.

UI-DEN-14936-1 29 Mar 2023

In post-treatment, there are a few states to work through to ensure reservoirs get drained:

/* Post-Treatment drain reservoirs state machine. */
typedef enum Drain_States
{
DRAIN_DG_DEPRIME_STATE = 0, ///< Drain DG De-prime dialysate lines of excess fluid state.
DRAIN_RESERVOIR_SWITCH_STATE, ///< Switch reservoir state.
DRAIN_RESERVOIR_START_DRAIN_STATE, ///< Drain reservoir start drain state.
DRAIN_RESERVOIR_DRAIN_STATE, ///< Drain first reservoir state.
DRAIN_RESERVOIR_COMPLETE_STATE, ///< Drain complete state.
NUM_OF_DRAIN_STATES ///< Number of drain states.
} DRAIN_STATE_T;

HD-DEN-15016-1 30 Mar 2023

Do you have data showing UI disappeared for > 5 seconds? Is this necessary?

DG-DEN-14646-1 29 Mar 2023

Spaces inside (). And explicit condition (i.e. ( TRUE == isConvNotValid ).

DG-DEN-14646-1 30 Mar 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-14937-3 31 Mar 2023

RESOLVED
[~vduong], When fixed please don't use "resolved", it is a keyword for our Bamboo scripts.
Thanks,

DG-DEN-15016-1 31 Mar 2023

Done. Does HD communicating always account for UI traffic as well?

DG-DEN-15016-1 31 Mar 2023

Reverted.

DG-DEN-15016-1 31 Mar 2023

Done

HD-DEN-15016-1 31 Mar 2023

Done.

HD-DEN-15016-1 31 Mar 2023

Done.

HD-DEN-15016-1 31 Mar 2023

I saw the corresponding alarm 44, on the initial power-up. However, going back to the UI log file shows UI communication within 1 second of triggering the error. So either the received message was that much delayed, or the check is otherwise broken.

DG-DEN-14999-2 31 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-15016-1 31 Mar 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-15016-1 31 Mar 2023

Space between ((

DG-DEN-15016-1 31 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-15016-1 30 Mar 2023

I think if HD not communicating, just clear the pending ack list - when HD revives, any pending messages in here are likely moot.

DG-DEN-15016-1 30 Mar 2023

No need to increase this one.

DG-DEN-15016-1 31 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15016-1 30 Mar 2023

My branch (and your DG branch) changed this to 10.

HD-DEN-15016-1 30 Mar 2023

Change back to 200.