•  

Comment Results

Review Name Created Custom Fields Content
TD-LEAH-60-1 17 Mar 2025

RESOLVED IN CODE WALKTHROUGH.

HD-DENBUG-298-1 17 Mar 2025

Changed the code.

HD-DENBUG-298-1 14 Mar 2025

Remove function prototype.

HD-DENBUG-298-1 18 Mar 2025

Yes

HD-DENBUG-298-1 18 Mar 2025

Did you remove this reject reason enum?

UI-LEAH-2077-2 19 Mar 2025

RESOLVED

HD-DEN-16565-1 22 Dec 2023

Don't make changes outside of user code sections.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Didn't you add a source param to these broadcast alarm functions?

DG-DEN-16565-1 02 Jan 2024

Why one handler for 3 commands?

HD-DENBUG-298-1 07 Mar 2025

Done

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

TBDL: Let's discuss more later.

Why is this removed?

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

HD-DEN-16672-1 14 Feb 2024

Mention periodic nature of this request. Use "fill" verbage instead of "open up".

UI-DEN-16533-1 21 Feb 2024

RESOLVED
I believe it has been explained in the comment as is same as the DG in the other comment.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

LEAHI-BOOTLOADER-LDT-3259-1 27 Feb 2026

Is Noe never going to change these IDs? I think he has already changed DD fpga ID for beta 2.0. If these IDs are not fixed forever, we cannot hardcode them here in the bootloader code.

HD-DEN-16672-1 27 Feb 2024

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

HD-DEN-16693-1 27 Feb 2024

All of these ternaries should say ... ? result : FALSE );

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

fixed it in commit ID 71a6797

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

DG-DEN-16674-1 29 Feb 2024

I don't see change. Did you push?

DG-DEN-16674-1 29 Feb 2024

Do this (request fill mode) in the testSetModeFillForCal() function above (and only if Dialin is logged in).

DG-DEN-16674-2 01 Mar 2024

Done

UI-LEAH-2077-2 18 Mar 2025

Structure is same for now. But please replace all references to "HD" to "TD".

UI-LEAH-2077-2 18 Mar 2025

Why do these 2 structure definitions need to be inside this #ifdef?

UI-LEAH-2077-2 18 Mar 2025

You are reserving 100..130 for UI triggered alarms? I guess that's ok, but not really necessary and causes alarm table to be larger than needed.

HD-DENBUG-298-1 18 Mar 2025

RESOLVED in CODE WALKTHROUGH.

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

Add blank line after declarations.

HD-DENBUG-298-1 18 Mar 2025

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1 14 Mar 2025

What are we doing here?

RO-LDT-566-5 18 Aug 2025

No and yes. This is for debugging purposes since Dialin will keep a history of events that have happened rather than the alarm module that will only contain the last received alarm trigger. I only want to keep this until we start enforcing alarms and transitioning into fault.

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

Should we have alarm here?

UI-LEAH-2077-2 18 Mar 2025

Why are all of these UI POST failures named with "..TD_UI.."? Shouldn't they just be "..UI.."? What does TD have to do with it?

UI-LEAH-2077-2 18 Mar 2025

Sean Nash,
I kept the same structure from Denali here as well.
if you are changing the alarms enums do you think we need to update this as well?

LEAHI-TESTSUITES-LDT-3014-1 02 Mar 2026

changed the code as per your suggestion to the check the advanced mode property in the file system.conf

DD-LEAH-230-3 31 Mar 2025

I liked the old name better.

LEAHI-TD-FIRMWARE-LDT-1903-8 02 Mar 2026

fixed

DD-LEAH-230-1 31 Mar 2025

Somewhere, we should be resetting some flags and FF value before we start a new control.

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

Add blank line after declarations.

DD-LEAH-230-1 31 Mar 2025

Should we change this back to target?

UI-LEAH-2077-2 19 Mar 2025

Why define '=16' here as number of enums but not in other enum definition? In consistent coding

HD-DENBUG-298-1 28 Mar 2025

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1 31 Mar 2025

RESOLVED in CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

updated

HD-DENBUG-298-1 18 Mar 2025

Execute TODO.

HD-DENBUG-298-1 04 Apr 2025

Yes. I think we should have these events to information.