Comment Search

RESOLVED IN CODE WALKTHROUGH.

I think VPi is closed during standby mode, so not sure why we want to check inlet conductivity in this mode.
I imagine new system would get installed by service - would need some kind of priming done in service mode, so I'm not worried about that.

Done.

RESOLVED in CODE WALKTHROUGH.

This looks backwards and nonsensical to me. Does this work?

This is not user code. Next regen will restore this code. Do we really need to disable this?

I think alarm should be handled inside the setAirPumpState() function.

Move this comment line right after alarm 99.

These 2 alarms are triggered by TD (6 is when TD fails the UI POST because UI reported a POST test failed and 9 is UI not communicating). They were ok the way they were. Please restore them. I only wanted you to change the ones you added at bottom of list.

For confirm button in create rx page we are using the visible property. If i remove the visible property not able to click on the element

RESOLVED

I check these against result since it is result &= ().

Is bootloader going to use fwcommon code? Is #ifdef #else backwards?

Do we reject saline bolus request if blood leak recovery is in progress? I think we should. I don't want a saline bolus requesting pending while blood leak recover is happening.

removed. thanks!

Assigned to local variable

Measured speed (whether real or override) should always be positive. And if that's true, we shouldn't need this exception.

This check doesn't make sense to me. Measured speed will only be negative if set direction is reverse. So how could directions ever not match?

Add a blank line between declarations and code.

removed

Updated

Please raname handler_spent_chamber_fill_sync() . Also do the same for the below broadcast interval function as well ( cmd_spent_chamber_fill_broadcast_interval_overirde)

It should be equal to true?

( getTestConfigStatus( TEST_CONFIG_DISABLE_BC_PRESSURE_ALARMS ) == TRUE )

timePerStep is not initialized with the values and being used here.

-isIdle || isWaitPump-
-just to be more clear.-

isIdle :start
isStarted : stop
-else: start-

disable the button otherwise.