•  

Comment Results

Review Name Created Custom Fields Content
DG-DEN-13989-2 12 Apr 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-13989-2 11 Apr 2023

0.0F, maybe a #define?

HD-DEN-15105-1 12 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15105-1 12 Apr 2023

Update header

HD-DEN-15049-1 13 Apr 2023

Still wrong though.

HD-DEN-15049-1 13 Apr 2023

RESOLVED in CODE WALKTHROUGH.

UI-LEAH-2077-2 19 Mar 2025

Thanks for catching that,
fixed.

HD-DEN-15049-1 13 Apr 2023

Corrected

HD-DEN-16565-1 22 Dec 2023

Do we really want to use a whole flash sector for a flag? I thought bootloader was going to talk to UI to determine whether an update was in progress?

HD-DEN-15049-1 12 Apr 2023

Comments appear to be swapped.

HD-DEN-15049-1 13 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15049-1 13 Apr 2023

They should remain. Will be uncommented when all DVT units have updated hardware.

HD-DEN-15049-1 13 Apr 2023

Are these alarms intentionally commented? Should they be activated or removed?

DG-DEN-16565-1 02 Jan 2024

This is not user code. Next regen will restore this code. Do we really need to disable ECC test code?

HD-DENBUG-298-1 25 Mar 2025

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-2 01 Mar 2024

RESOLVED IN CODE WALKTHROUGH

HD-DENBUG-298-1 20 Mar 2025

Also reject if in treatment stop state and recovering from blood leak alarm.

HD-DEN-15049-1 13 Apr 2023

Removed

LEAHI-APPLICATION-LDT-1616-1 16 Sep 2025

i agree

HD-DEN-15105-1 13 Apr 2023

Fixed.

HD-DEN-16693-1 05 Mar 2024

RESOLVED in CODE WALKTHROUGH.

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

Alarm should be handled inside of setAirPumpState().

HD-DEN-15049-1 13 Apr 2023

Corrected

HD-DEN-16672-2 05 Mar 2024

Done.

HD-DEN-15049-1 13 Apr 2023

Corrected

HD-DEN-15105-1 13 Apr 2023

Fixed.

HD-DEN-15049-1 13 Apr 2023

Corrected

HD-DEN-15049-1 13 Apr 2023

Corrected

HD-DEN-15049-1 13 Apr 2023

I think we can just say "if ( TRUE == hasPowerBeenLost )" here. Zero trigger persistence time now that CPLD is making determination.

UI-DEN-16657-3 06 Mar 2024

RESOLVED.
clossing.

HD-DEN-15049-1 13 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15049-1 13 Apr 2023

I think we can fit this whole comment on the 1 line. Bring closer to break; if need more room.

UI-DEN-16657-9 06 Mar 2024

the application branch has no code change the changes are made on the ui.script
this CR will be closed.

HD-DEN-15049-1 13 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15049-1 13 Apr 2023

Remove this method of determine whether AC power has been lost. CPLD function above is what we want.

HD-DEN-15049-1 13 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15049-1 13 Apr 2023

We want to use CPLD for this. Keep this line, remove line below where initialized to FALSE.

HD-DEN-15105-1 13 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15105-1 13 Apr 2023

Should be dgPOSTPassed.

HD-DEN-15049-1 13 Apr 2023

No longer needed?

HD-DEN-15049-1 13 Apr 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-16687-1 07 Mar 2024

Done

HD-DEN-15105-1 13 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15105-1 13 Apr 2023

Update header.

SCRIPTS-DEN-16686-1 08 Mar 2024

Done

HD-DEN-16693-1 08 Mar 2024

We did not check for the upper limit in the past, does this add new rejection scenarios

DD-LEAH-230-1 31 Mar 2025

Should this be a constant?

HD-DEN-15105-1 13 Apr 2023

Update header

HD-DEN-15105-1 13 Apr 2023

Update header.

UI-DEN-16687-1 11 Mar 2024

RESOLVED