•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DEN-15166-1 18 Apr 2023

Done

DG-DEN-15166-1 18 Apr 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-15166-1 18 Apr 2023

Why call this "isRPMTooHigh" but compare the rpm against the "MIN_DRAIN_PUMP_RPM"? Between MIN and MAX would be the natural valid range, similar to "isRPMOutOfRange", below.

UI-DEN-14947-4 19 Apr 2023

Wrong place. This table should be in enum order so this should be added to end of table.

UI-DEN-14947-4 19 Apr 2023

this CR needs Sean Nash, and/or Dara Navaei review for the AlarmDefs.h.

UI-DEN-14947-4 19 Apr 2023

I reviewed. One comment re: improper placement in table.
RESOLVED.

UI-DEN-14947-4 19 Apr 2023

RESOLVED.

DIALIN-DEN-15166-1 17 Apr 2023

Inline comments are usually present describing each enum.

DIALIN-DEN-15166-1 19 Apr 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-13989-2 19 Apr 2023

Corrected.

HD-DEN-15183-1 20 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15183-1 20 Apr 2023

Fixed.

HD-DEN-15183-1 20 Apr 2023

Fixed.

HD-DEN-15183-1 19 Apr 2023

Add doorOpened to header.

HD-DEN-14325-2 20 Apr 2023

It is not needed. So I removed it.

HD-DEN-14325-2 20 Apr 2023

Needed?

HD-DEN-14325-2 20 Apr 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-15183-1 20 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15183-1 19 Apr 2023

Add treatmentTimeBroadcastTimerCtr to header.

HD-DEN-14980-1 21 Apr 2023

Done.

HD-DEN-14980-1 21 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14980-1 20 Apr 2023

Add alarmStatus to header

HD-DEN-15183-1 21 Apr 2023

Fixed.

HD-DEN-15183-1 21 Apr 2023

Fixed.

HD-DEN-15183-1 21 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15183-1 20 Apr 2023

Add testStartTime, audioTestStartTime, alarmAudioTestToneRequested and to header

DG-DEN-13989-2 18 Apr 2023

Align "="

HD-DEN-15183-1 21 Apr 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-15183-1 20 Apr 2023

Extra blank line.

DG-DEN-15199-1 21 Apr 2023

Are DG and HD sharing this enum?

HD-DEN-16672-2 05 Mar 2024

Comment should be /// (3, not 2) for doxygen to pick it up.

UI-DEN-16657-3 06 Mar 2024

No code change for this branch on application repository.
will be closed.

DG-DEN-15199-1 21 Apr 2023

testConfig is an input, not an output.

DG-DEN-15199-1 21 Apr 2023

Add check for Dialin logged in.

DG-DEN-15199-1 21 Apr 2023

Add blank line between banner and #define.

HD-DENBUG-298-1 20 Mar 2025

The saline bolus state is checked in the below else if

UI-DEN-16687-1 11 Mar 2024

RESOLVED

HD-DEN-16693-1 07 Mar 2024

Done

HD-DEN-16693-1 07 Mar 2024

Cast constant as (F32) as before.

RO-LEAH-273-1 25 Mar 2025

Fixed. Thanks!

HD-DENBUG-298-1 21 Mar 2025

These alarms we're demoting from HD fault should have their ranks demoted to 110 (like DG faults).

HD-DEN-16693-1 07 Mar 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16693-1 07 Mar 2024

Add minimum check here too.

HD-DENBUG-298-1 25 Mar 2025

Done

UI-DEN-16687-1 11 Mar 2024

This is the model section.
please move to the view section.

DIALIN-DEN-16693-2 11 Mar 2024

This module seems to be missing from the code review

RO-LEAH-273-1 25 Mar 2025

If monitoring not yet implemented, that's ok - but at least add a TODO comment.

HD-DEN-16773-1 18 Mar 2024

Put this in an else below.

SCRIPTS-DEN-16686-1 08 Mar 2024

Generally, as has been decided the current code should be untouched and just adding some extra functionality.
Therefore, some block of code shall be seen to be added not the entire script.
please keep your modifications only to what is changed and try to do not change the entire code.

The code changes should be so surgical in very focused space not everywhere.

Thanks

HD-DENBUG-298-1 26 Mar 2025

Done