•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

removed

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

updated cpp files

RO-LDT-1809-3 26 Aug 2025

We want 2 blank lines before and after test support banner. So restore this deleted row.

DD-LDT-2030-1 26 Aug 2025

Update function headers to Leahi style.

LEAHI-SW-LDT-2071-1 18 Aug 2025

Can you change to say TD Main Treatment Data

TD-LDT-1735-1 22 Aug 2025

Please update the comments for Pressure alarm and Diener pump.

RO-LDT-1242-1 22 Aug 2025

I see a couple faults down here at rank 110 - seems high for a fault. Should be 10 I think.

LEAHI-APPLICATION-LDT-1788-2 08 Sep 2025

CR with no code change, and the Story is already closed/AlphaComplete.
Closing this CR.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

Can we remove this line of code?

DIALIN-DEN-15014-1 28 Mar 2023

Done

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Added

LEAHI-TD-FIRMWARE-LDT-1903-8 26 Feb 2026

I don't like controller bypassing driver to get to fpga access functions. There should be a get function in the driver that we can call here instead.

HD-DEN-16565-1 22 Dec 2023

This is adding conversion to binary step post-build, correct? Are we losing the alarm check here?

DG-DEN-16565-1 22 Dec 2023

Why aren't we calling the specific handlers for reboot and enter bootloader commands?

DG-DEN-16565-1 02 Jan 2024

This is not user code. Next regen will restore this code. Do we really need to remove this code?

TD-LEAH-60-1 16 Mar 2025

DG to DD

HD-DEN-16595-2 08 Jan 2024

RESOLVED in CODE WALKTHROUGH

DG-DEN-16587-1 14 Feb 2024

Updated.

HD-DENBUG-298-1 26 Mar 2025

RESOLVED in CODE WALKTHROUGH.

UI-DEN-16533-1 20 Feb 2024

RESOLVED
fixed.

DRY-DEMO-DEN-16657-2 21 Feb 2024

RESOLVED
Closed.

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

Remove this block or set to empty for now.

After aligning the code to make it easier to read, it appeared to me that it should not be correct.
I would like you to remove the parts that are not fully implemented and have not been decided upon for FW, such as this one.

property string ufVolumeDescriptionText :   isTreatmentPaused || vTDTreatmentStates.txDialysis   ?  ""                  :
                                            isUFRunning       || isUFPaused                      ?  qsTr("Isolated UF") :
                                                                                                    ""
HD-DEN-16672-1 26 Feb 2024

Done.

HD-DEN-16672-1 22 Feb 2024

The lower level sensor doesn't need to be raw here.

HD-DEN-16672-1 27 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1 29 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1 18 Mar 2025

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-298-1 28 Mar 2025

Add comment explaining what we're doing here.

UI-LEAH-2077-2 18 Mar 2025

I believe I replaced all HD references to TD already,
Could you be more specific.
I only found one "_HD" and it is not in my range of defined alarms.

 { 24  , ALARM_ID_HD_ALARM_AUDIO_SELF_TEST_FAILURE                     , "TD    | Service Required: Hemodialysis Device   | A problem was detected with the hemodialysis device.\n- Locate the ID code found in the bottom left corner\nof the alarm screen.\n- Call service to report the issue and schedule a repair.                                                                                                                                                                                                                           | TD POST: Primary Alarm Current           | TD alarm audio failed POST                                                                                                                | If alarm audio current is NOT in expected range for than 1 second while alarm tone is being output                                                                                                                                                                               | "},
DG-DEN-16674-2 01 Mar 2024

Can we bring a parenthesis for better readability?

HD-DEN-16693-1 01 Mar 2024

This alarm should be restored.

UI-LEAH-2077-2 19 Mar 2025

revert them back to its original.

UI-LEAH-2077-2 19 Mar 2025

RESOLVED

RO-LEAH-273-1 25 Mar 2025

Fixed. Thanks!

HD-DENBUG-298-1 25 Mar 2025

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 17 Mar 2025

Please add parentheses for each condition for better readability.

HD-DENBUG-298-1 25 Mar 2025

Last condition is wrong (dialysate recirc blocked). Should be no rinseback.

DG-DENBUG-307-1 02 Apr 2025

Not needed, but benign. RESOLVED in CODE WALKTHROUGH.

DD-LEAH-230-1 02 Apr 2025

Removed.

DD-LEAH-230-1 02 Apr 2025

Removed.

DD-LEAH-230-1 31 Mar 2025

Do we still need to support other versions?

UI-DEN-17260-1 03 Apr 2025

I think I was wrong.
this like should return default

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

same

LEAHI-APPLICATION-LDT-1209-1 15 Jul 2025

Please refactor any structure, model, view, qml object, usage of TreatmentSetPoint (the naming is too general and confusing) to TreatmentParametersSetPoint.
And please test with the simulator to ensure it is working as expected.

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

removed

RO-LDT-1809-3 26 Aug 2025

Add a comment here to help reader understand what we're doing.

RO-LDT-1809-3 26 Aug 2025

Cannot return here.

RO-LDT-1242-1 22 Aug 2025

Add comments to right of #defines.