•  

Comment Results

Review Name Created Custom Fields Content
DIALIN-DIAL-290-1 16 Feb 2024

Sync'd with Vinay. New state has been added.

HD-DEN-16672-1 20 Feb 2024

Done.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

HD-DEN-16672-1 20 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16672-1 14 Feb 2024

Var is not really an input. Just an output.

HD-DEN-16565-1 22 Dec 2023

So app start address is offset by 64K. Assuming that is plenty of room for bootloader but we should check.
Also, have we checked that the first 64K of Flash memory is discreet sector-wise? We do not want bootloader and app sharing a sector.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

HD-DENBUG-162-1 25 Jan 2024

Done.

RO-LEAH-273-1 11 Mar 2025

We're gonna check for illegal state in the exec function instead of each state function.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

DG-DEN-16674-1 29 Feb 2024

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 11 Mar 2025

We're gonna check for illegal state in the exec function instead of each state function.

HD-DENBUG-162-1 05 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-163-1 05 Feb 2024

Done.

HD-DEN-16563-1 05 Feb 2024

Add space between if and (. Add to comment that low venous pressure must be exempt to increment counter.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

HD-DENBUG-163-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-163-1 02 Feb 2024

I think the idea was to have a shorter persistence for the high venous pressure only. Low venous pressure would stay at 1 second as before.

HD-DENBUG-163-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

DG-DEN-16587-1 15 Feb 2024

Question was in relation to DG gen idle sub-state, not HD mode.

UI-DEN-16657-1 16 Feb 2024

RESOLVED
and will be closed.

HD-DENBUG-163-1 21 Feb 2024

Done.

HD-DENBUG-163-1 21 Feb 2024

use new get function for raw levels in this condition so that raw override is considered.

HD-DENBUG-163-1 21 Feb 2024

use new get function for raw levels in this assignment so that raw override is considered.

HD-DENBUG-163-1 21 Feb 2024

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 06 Mar 2025

Add blank line before return statement.

HD-DEN-16672-1 23 Feb 2024

Why is air pump on state checked here? Seems redundant as it is checked again below.

RO-LEAH-273-1 06 Mar 2025

Add blank line before return statement.

HD-DEN-16672-1 28 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1 29 Feb 2024

Done

DG-DEN-16674-1 29 Feb 2024

But this comment also asked that you remove the transition to fill mode here and add it to the fill mode function called above. It's still here.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

DG-DEN-16674-1 27 Feb 2024

All of these for loops are not following our coding standards. Should have bracketed scope even if single line of code in loop.

DG-DEN-16674-1 29 Feb 2024

Done. Added a check in the function in the Mode Fill like the rest of the modes and drivers.

DG-DEN-16674-1 29 Feb 2024

Done

RO-LEAH-273-1 11 Mar 2025

Removed.

DG-DEN-16674-1 29 Feb 2024

Done

DG-DEN-16674-1 29 Feb 2024

Make sure Dialin is logged in before accepting command.

RO-LEAH-273-1 13 Mar 2025

Fixed. Thanks!

DG-DEN-16674-1 29 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1 29 Feb 2024

If this is a Dialin command, make sure Dialin is logged in before acting on it (throughout this module).

DG-DEN-16674-1 29 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16674-1 29 Feb 2024

If these are Dialin commands, add a condition around this switch that Dialin has logged in.

RO-LEAH-273-1 06 Mar 2025

I feel like this unit should not be calling a driver level function directly. There should be a layer in ROPump.c between the driver and high level units like DDInterface.

DG-DEN-16674-1 29 Feb 2024

No I will check the Dialin check in the function like the rest of the commands from Dialin.

HD-DENBUG-298-1 14 Mar 2025

Need to check to see if start bolus signal (request) is pending. As written, we will always go to saline bolus state from any other state.