Fixed. Thanks!
RESOLVED IN CODE WALKTHROUGH.
http://devapps.diality.us:8060/cru/UI-DEN-16597-29 RESOLVED
I don't think this state should have a delay. When we see high level, we should switch immediately.
Add blank line before return statement.
Done
RESOLVED
function header says return type as void.
Looks this timer is being not used in low state timeout.
RESOLVED in CODE WALKTHROUGH.
Done.
this is a general implementation and should not use specific value modification. this should follow the correct between braces format. If you need to round up do it outside in your specific case.
Updated popup
use only isDefault
Add comment to right. And it looks like this flag only relates to flow control - so variable name and comment should reflect that.
Removed.
Can we remove this commented line? Seems redundant anyway.
Set auto resume to TRUE.
Swapped.
Fixed
Align comments or remove them (not necessary for function prototypes).
Resolved the behavior in latest commit.
Looks like it's still here.
Add a comment.
Cannot return here.
Added comment line
Faults shouldn't have ClrOnly set to TRUE.
fp simulator?
Change to ( skipSet != TRUE )
Update per f/w name change from code review.
Spaces in ().
Should we use new reboot function in Update.c?
I think we should add the detection to the log like air or fluid.
Got a suggestion or an issue? Discuss it on the Atlassian Community or visit Atlassian Support for other options.
