•  

Comment Results

Review Name Created Custom Fields Content
HD-DENBUG-163-1 05 Feb 2024

Done.

HD-DEN-16563-1 05 Feb 2024

I think reset flag should not be set here. Should be set by new function when valve is closed I think.

HD-DEN-16563-1 05 Feb 2024

Should also set new flag to FALSE here I think.

HD-DENBUG-298-1 21 Mar 2025

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16563-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-163-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16587-1 01 Feb 2024

This should be a fault alarm. Like the properties of alarm 189 (drain pump RPM out of range)

UI-DEN-16526-3 06 Feb 2024

RESOLVED

HD-DEN-16666-1 08 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DD-LEAH-230-1 31 Mar 2025

Can we remove these commented out #defines?

DD-LEAH-230-1 31 Mar 2025

Remove support for other versions?

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

updated

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

keep

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

move isRunning property inside of ProgressCircle

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

REMOVED ALIAS

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

created IconButton.qml

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

all edits to this file have been reverted since we are no longer using it

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

exposed the diameter and updated actual image to match this

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 14 Jul 2025

This whole component has now been removed

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

This is a duplicate.
Please remove it.

LEAHI-APPLICATION-LDT-1209-1 15 Jul 2025

added

LEAHI-APPLICATION-LDT-1209-1 15 Jul 2025

Put functions on top of the qml files after defining properties.

RO-LDT-566-4 19 Aug 2025

Realign comments.

LEAHI-SW-LDT-2071-1 18 Aug 2025

updated

RO-LDT-1928-3 18 Aug 2025

Similar to how we have the if statement above, please assign the state to FP_PRE_GENP_FILTER_FLUSH once we complete the pressure check.

RO-LDT-1928-3 20 Aug 2025

Done.

LEAHI-APPLICATION-LDT-926-1 19 Aug 2025

For the models, in their infoText functions, use QStringLiteral when generating the string that is getting returned, if possible.
(https://doc.qt.io/archives/qt-5.15/qstring.html#QStringLiteral)

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

updated

DG-DEN-15014-1 28 Mar 2023

I did. I still see a call to sendAckResponseMsg() and I don't think it should be here.

HD-DEN-16565-1 22 Dec 2023

Spaces inside (). Use ternary to set to TRUE or FALSE explicitly.

LEAHI-TD-FIRMWARE-LDT-3259-1 27 Feb 2026

Has integrity unit been added to TD project?

RO-LDT-566-4 19 Aug 2025

This "if" is not necessary. Just assign to TRUE regardless.

HD-DEN-16565-1 22 Dec 2023

Why aren't each of these messages calling their own handler function? They appear to exist in SystemCommMessages.c so I believe that was the intent.

DG-DEN-16565-1 02 Jan 2024

#if 1 and #endif appear to be unnecessary. Remove.

HD-DEN-16518-1 15 Jan 2024

Updated code changes. Open loop still maintains the minimum PWM duty cycle as 10%.

RO-LEAH-273-1 06 Mar 2025

Next state, not current state.

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Removed and replaced

HD-DENBUG-162-1 25 Jan 2024

Add OR condition for if useShort == FALSE

HD-DEN-16563-1 05 Feb 2024

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, flag is set back to TRUE and Exempt counter being incremented.

HD-DENBUG-163-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 06 Mar 2025

Not necessary to check here if you check it globally in exec.

LEAHI-TD-FIRMWARE-LDT-1903-8 27 Feb 2026

Can we remove inclusion of fpga here? It shouldn't be needed.

RO-LEAH-273-1 11 Mar 2025

Remove blank line.

HD-DEN-16666-1 08 Feb 2024

Done