•  

Comment Results

Review Name Created Custom Fields Content
HD-DENBUG-162-1 02 Feb 2024

period should be plural in comment and enum names.

HD-DENBUG-162-1 05 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16587-1 05 Feb 2024

Dara meant for you to add units to end of name (i.e. MAX_IDLE_RSVR_WEIGHT_GAIN_ML).

DG-DEN-16587-1 02 Feb 2024

inactive misspelled in comment.

DG-DEN-16587-1 02 Feb 2024

Use 2 U32 Data macro and log initial weight as well.

HD-DEN-16563-1 05 Feb 2024

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, flag is set back to TRUE and Exempt counter being incremented.

HD-DEN-16563-1 05 Feb 2024

Done. Removed the parameter in function.

HD-DEN-16563-1 05 Feb 2024

Done.

HD-DEN-16563-1 05 Feb 2024

lowVenousPressureExemptCheck - flag initialized to TRUE in the Init routine. Whenever valve opens (fill), it resets the flag to "FALSE" ,the Exempt counter is not incremented. When valve closes, flag is set back to TRUE and Exempt counter being incremented.

HD-DENBUG-163-1 05 Feb 2024

Done.

HD-DENBUG-163-1 05 Feb 2024

Done.

HD-DENBUG-163-1 05 Feb 2024

Done.

HD-DEN-16563-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16563-1 05 Feb 2024

I think this function should set the old reset flag to FALSE here. Function doesn't need a parameter because it is only called when valve closes which should always set reset flag to FALSE.

HD-DEN-16563-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16563-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16563-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-162-2 31 Jan 2024

Remove space before comma.

HD-DENBUG-162-2 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-163-1 06 Feb 2024

RESOLVED in CODE WALKTHROUGH.

DG-DEN-16587-1 01 Feb 2024

Please add the unit at the end of the #define

DG-DEN-16587-1 06 Feb 2024

RESOLVED in CODE WLAKTHROUGH

DG-DEN-16587-2 08 Feb 2024

Updated.

DG-DEN-15014-1 28 Mar 2023

What I meant is that we don't need to send anything other than response.

HD-DEN-16565-1 22 Dec 2023

This message will not get sent immediately - it is only queued. Reset will occur before transmit.

HD-DEN-16565-1 22 Dec 2023

Why not call the reboot function in Update.c?

RO-LEAH-273-1 13 Mar 2025

Fixed. Thanks!

HD-DENBUG-298-1 18 Mar 2025

Update comment to remove max.

DIALIN-DEN-15014-1 28 Mar 2023

Are these prints permanent? May slow dialin down a bit.

HD-DEN-16499-1 25 Jan 2024

This looks wrong.

HD-DENBUG-298-1 07 Mar 2025

Probably not this simple.
We need to consider how much UF volume we've done so far and how much Tx time is remaining.
So rate = ( presMaxUFVolumeML - collectedUFVolumeML ) / treatmentTimeRemaining.
I made up var names for all but the first in equation above, but just showing how the calculation should go. You can look at UF volume change (where we are changing UF rate to accomodate the change) for reference.

HD-DENBUG-162-1 05 Feb 2024

Done.

HD-DENBUG-162-1 02 Feb 2024

Maybe just name this stabilization 2.

HD-DENBUG-162-1 02 Feb 2024

This should just be "else". Think about which of the 3 possibilities should be the else - maybe the normal period.

HD-DENBUG-162-1 05 Feb 2024

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16391-3 02 Jan 2024

Discussed with Sean and confirmed that matching requirement done in the code. We are good with the modification now.

RO-LEAH-273-1 06 Mar 2025

Remove blank line.

HD-DEN-16518-1 15 Jan 2024

Do we want to have the 11% minimum here? I thought it was just for closed loop control.

UI-DEN-16597-28 17 Jan 2024

another CR has been created due to some commit issues on the review branch.

RO-LEAH-273-1 11 Mar 2025

changed the variable to no longer be overridable. Removed override function.

UI-DEN-16490-1 17 Jan 2024

RESOLVED

DG-DEN-16587-1 09 Feb 2024

DG idle reservoir out of range - rewording " DG idle reservoir weight out of range" would be better?

HD-DENBUG-298-1 07 Mar 2025

RESOLVED in CODE WALKTHROUGH.

HD-DENBUG-162-1 02 Feb 2024

You already did this in prior state.

DG-DEN-16587-1 05 Feb 2024

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 06 Mar 2025

We would be returning the "next" state, not the current state.

HD-DENBUG-162-2 05 Feb 2024

Done.

HD-DENBUG-163-1 05 Feb 2024

Done.

HD-DEN-16563-1 05 Feb 2024

Shouldn't this be set to TRUE?

RO-LEAH-273-1 06 Mar 2025

I believe Jenna wanted an alarm for this situation - though you may want a bit of persistence before you trigger it.
I see you have these else conditions in all 3 states. I think we can check for this once in a check function that gets called from the exec no matter which state we're in.