•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14689-1 17 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14689-1 17 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14689-1 17 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14689-1 17 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14689-1 17 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-13794-1 17 Mar 2023

No change.

HD-DEN-14689-1 17 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 17 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 17 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 17 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 17 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 17 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 17 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 17 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 17 Mar 2023

Fixed. Thanks!

HD-DEN-14689-1 17 Mar 2023

Reverted change. We will revisit this in an upcoming branch.

DG-DEN-14763-1 18 Mar 2023

This is to find the target configuration which in our case it is XDS-110 automatically. It seems the .ccxml file in the targetConfigs folder sets the right debugger and target regardless of this check box being true or false. I set it back to true to be consistent.

DG-DEN-14763-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1 20 Mar 2023

Everything else in this function should be in an else body if given reservoir ID is invalid so we don't try to use an invalid ID.

DG-DEN-14763-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14689-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 13 Mar 2023

Is it ok to ignore P if package has already been started? Should this ever happen?

DG-DEN-14763-1 20 Mar 2023

Not all of these are disinfect usage (e.g. RO water generated) so I don't think disinfect_usage is appropriate. I am ok with usage_info, though I think DG_USAGE_INFO is better.

HD-DEN-14763-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14689-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1 20 Mar 2023

Done

DG-DEN-14763-1 20 Mar 2023

Done

DG-DEN-14763-1 20 Mar 2023

Done. Thanks for catching it.

HD-DEN-14763-1 20 Mar 2023

Reverted back. Thanks for catching it.

HD-DEN-14763-1 20 Mar 2023

Done

HD-DEN-14763-1 20 Mar 2023

Done

DG-DEN-14763-1 20 Mar 2023

Why lower case when others are uppercase?

DG-DEN-14763-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14763-1 20 Mar 2023

Missing comment?

DG-DEN-14763-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14763-1 20 Mar 2023

Update comment.

HD-DEN-14763-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14763-1 20 Mar 2023

size was right.

HD-DEN-14763-1 20 Mar 2023

Since these are Dialin commands (0x8... msg IDs), we should require login before calling hard stop functions.

HD-DEN-14763-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14689-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14689-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14689-1 27 Feb 2023

I think FALSE was more appropriate. Last param indicates whether this ACK msg is an ACK (T) or NAK (F).

HD-DEN-14689-1 20 Mar 2023

RESOLVED in CODE WALKTHROUGH.