•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-853-1 08 Jul 2025

After addressing the following comment, this image will be removed and handled by the button properties.
http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-853-1CFR-69101

DD-LDT-1873-1 18 Aug 2025

Remove extra blank line.

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

REMOVED

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove for now

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove drop shadow

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

create properties instead of alias

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 08 Jul 2025

Please use only the internal icon with a transparent background for the button image so that we can have more options for background colors.

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

set to empty and added TODO

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

RESOLVED.

LEAHI-APPLICATION-LDT-1209-1 14 Jul 2025

updated and removed

LEAHI-APPLICATION-LDT-926-1 18 Aug 2025

probably do not need to translate because its a diagnostics page but to keep consistent with all other user facing texts in this file please translate.

TD-LDT-736-1 17 Jul 2025

I am. Didn't want to wait (up to 50ms) for pump to stop if hard stop is requested. So forcing to off immediately. Not how I would ordinarily want to handle this, but in this case I am.

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

updated naming

LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

Thanks for updating the names.
Please make the object name match the Component name.
While you are doing that, could you also please remove the Dialog from the new name:

HeaderbarWiFi         { id: _headerbarWifi                  }
HeaderbarInformation  { id: _headerbarInformation           }
RO-LDT-1809-3 20 Aug 2025

These code lines are removed in latest commit

RO-LDT-566-5 18 Aug 2025

Is this adding anything that the trigger alarm message doesn't already do?

RO-LDT-566-4 19 Aug 2025

Should this be an "else if"?

RO-LDT-1928-3 20 Aug 2025

Yeah, I agree.
We can remove it

DD-LDT-1735-1 25 Aug 2025

Fixed.

RO-LDT-1928-3 19 Aug 2025

If check completed, are we stuck in this state forever?

RO-LDT-1809-3 26 Aug 2025

Removed multiple return

LEAHI-DIALIN-LDT-1873-1 27 Aug 2025

Done

LEAHI-APPLICATION-LDT-1063-1 28 Aug 2025

can you add FP version info placeholders as we did in the popup

             
        { name: qsTr("FP Version"       ) , value: vAdjustmentVersions.fpVerDevice  },
        { name: qsTr("FP FPGA Version"  ) , value: vAdjustmentVersions.fpVerFPGA    },
DD-LDT-1735-1 29 Aug 2025

Fixed .

DD-LDT-2030-1 29 Aug 2025

110 has been used in another branch.

DD-LDT-2030-1 27 Aug 2025

When will we un-comment? And why did we need to comment it out now?

LEAHI-APPLICATION-LDT-2071-1 29 Aug 2025

Update to TD

TD-LDT-2043-1 29 Aug 2025

Fixed.

RO-LDT-1242-1 22 Aug 2025

6 seconds seems too brief to me. Is this just a placeholder?

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

added this

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16565-1 22 Dec 2023

Need doxygen group stuff here.

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 05 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 05 Mar 2025

its not a count per time but a count of general task ticks. Its used to determine when we hit the interval period.

RO-LEAH-273-1 04 Mar 2025

What is difference between water delivery in progress and gen permeate state?

RO-LEAH-273-1 05 Mar 2025

And the general task tick time is 50ms (20 Hz).

RO-LEAH-273-1 04 Mar 2025

Keep include lists in alphabetical order.

RO-LEAH-273-1 04 Mar 2025

Why does this need to be public?

RO-LEAH-273-1 17 Mar 2025

Are we using this flowrate here? it seems only level is being used for state transition.

TD-LEAH-60-1 16 Mar 2025

Will you be adding override message later?

HD-DENBUG-298-1 07 Mar 2025

RESOLVED in CODE WALKTHROUGH.

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 11 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 06 Mar 2025

Remove extra space between U32 and var name. That will also align comment.

RO-LEAH-273-1 06 Mar 2025

stateDelayTime is at least one input.