•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-853-1 08 Jul 2025

Move that back to the compounds.

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

Please ensure that all images used in this component are the same size, so we do not need to add extra code to handle those properties.

LEAHI-APPLICATION-LDT-853-1 11 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-1209-1 11 Jul 2025

To align, do it like the following:

extraText       :   vTreatmentSetPoint.dialysateFlow === 0  ||
                    vTDTreatmentStates.txIsolatedUf         ?   qsTr("OFF"   ) :
                  ! vDDGenDialysate.isDialGood              ?   qsTr("Bypass") :
                    ""
LEAHI-APPLICATION-LDT-1636-1 15 Aug 2025

RESOLVED

DD-LDT-1873-1 18 Aug 2025

isPressureDroppedDuringFill not initialized in init function.

LEAHI-DIALIN-LDT-783-1 18 Aug 2025

RESOLVED

LEAHI-SW-LDT-2071-1 18 Aug 2025

done

RO-LDT-1928-3 19 Aug 2025

Align comments.

RO-LDT-566-4 19 Aug 2025

Are we going to change back to duty cycle % as control signal output?

RO-LDT-566-4 19 Aug 2025

Remove extra blank line.

RO-LDT-566-4 19 Aug 2025

Align "=".

RO-LDT-566-4 19 Aug 2025

Where did these move to?

RO-LDT-1928-3 19 Aug 2025

Updated, thanks.

RO-LDT-1928-3 19 Aug 2025

Removed.

RO-LDT-1928-3 18 Aug 2025

Remove commented function header.

RO-LDT-1928-3 18 Aug 2025

Please remove unnecessary #include's like ROPump, PermeateTank, Conductivity, etc.

RO-LDT-1809-3 26 Aug 2025

Add new @param to function header.

RO-LDT-1809-3 19 Aug 2025

Declare result at top of scope. Keep assignment here.

RO-LDT-1809-3 20 Aug 2025

Removed

RO-LDT-1928-3 20 Aug 2025

Yes, will be in paused state, until we do the PreGen mode again.

RO-LDT-1809-3 19 Aug 2025

Do we not still need to zero these other targets in these set functions?

LEAHI-APPLICATION-LDT-926-1 28 Aug 2025

Understood, will consider in a future story to adjust all models

RO-LDT-1809-3 26 Aug 2025

Moved to FluidPump

RO-LDT-1928-3 27 Aug 2025

Done

DD-LDT-2030-1 27 Aug 2025

Done

RO-LDT-1928-3 19 Aug 2025

Add a blank line before group end marker.

LEAHI-APPLICATION-LDT-1063-1 29 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

reverted

HD-DEN-14906-1 15 Mar 2023

Removed

HD-DEN-14906-1 15 Mar 2023

Done

HD-DEN-16565-1 22 Dec 2023

Why do we need this function? Why not just use the reset function below to start the bootloader?

HD-DEN-14906-1 15 Mar 2023

Comment should say with, not without.

LEAHI-DD-FIRMWARE-LDT-3372-2 27 Feb 2026

its a public function , input parameter check required, apply to all public functions

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16565-1 22 Dec 2023

Spaces in (). Be explicit on BOOL conditions.

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

has been removed

RO-LEAH-273-1 05 Mar 2025

Fixed. Thanks!

RO-LEAH-273-1 05 Mar 2025

Fixed. Thanks!

DG-DEN-14763-1 16 Mar 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14763-1 16 Mar 2023

RESOLVED IN CODE WALKTHROUGH

RO-LEAH-273-1 05 Mar 2025

Based on the discussion we had earlier yesterday, i dont need that variable as the DD will be managing it and this mode is only monitoring the level sensors.

RO-LEAH-273-1 04 Mar 2025

What is "idle" state doing that needs to be paused?

RO-LEAH-273-1 04 Mar 2025

Align "=".

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

change to 2 decimals. Note Variables may have a decimal property

RO-LEAH-273-1 04 Mar 2025

Why need comment here?

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Removed

LEAHI-DD-FIRMWARE-LDT-3372-2 27 Feb 2026

need math formula as documentation

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

removed using marker alias

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

updated to this