•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-APPLICATION-LDT-926-1 28 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-926-1 28 Aug 2025

fixed, thanks!

LEAHI-APPLICATION-LDT-2071-1 29 Aug 2025

updated

LEAHI-APPLICATION-LDT-926-1 29 Aug 2025

RESOLVED

LEAHI-APPLICATION-LDT-2160-1 08 Sep 2025

updated for this behavior

LEAHI-DD-FIRMWARE-LDT-2198-1 09 Sep 2025

If we don't need these, remove them.

UI-DEN-14909-1 13 Mar 2023

Why In-Line Component is used.
The idea behind the loader is to set them active if only it is set active.
Does the in-line component have the same efficiency?
Please test and provide proof of concept, since this feature is very new and I haven't tested it.
If can't be proven, use the loader only, please.

HD-DENBUG-326-1 10 Sep 2025

We are only debouncing the transition from detected to not detected (syringe removal). Is that our design intent?

HD-DEN-16512-1 27 Nov 2023

Add space after if.

HD-DEN-14906-1 15 Mar 2023

Done

HD-DEN-14906-1 14 Mar 2023

Timer counter is reset in both cases so should be done once before or after the in progress condition is checked.

HD-DEN-14906-1 14 Mar 2023

Generally don't like static variables declared locally in function. Initialization is tricky. Would move to module level scope if needed at all. I don't think it is needed if you command pumps to zero before you get to this state.

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16391-1 28 Nov 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

Done

HD-DEN-16391-1 27 Nov 2023

Remove blank line.

HD-DEN-14906-1 16 Mar 2023

Handled minimum UF rate in another branch. Implemented the rest here.
RESOLVED in CODE WALKTHROUGH.

UI-DEN-17157-1 25 Feb 2025

RESOLVED

HD-DEN-14906-1 16 Mar 2023

Fixed.

HD-DEN-16391-1 28 Nov 2023

RESOLVED in CODE WALKTHROUGH.

UI-DEN-17157-1 25 Feb 2025

RESOLVED

UI-DEN-17157-1 25 Feb 2025

is there a specific reason the notSetVariable function is not used and replaced with "__"?

LEAHI-APPLICATION-LDT-853-1 07 Jul 2025

updated to use row/column

RO-LEAH-273-1 04 Mar 2025

DDInterface

LEAHI-DD-FIRMWARE-LDT-3372-2 27 Feb 2026

Need a detailed name for variable - apply for all other

LEAHI-APPLICATION-LDT-627-1 03 Jul 2025

fixed

LEAHI-APPLICATION-LDT-627-1 03 Jul 2025

RESOLVED

LEAHI-DD-FIRMWARE-LDT-3372-2 27 Feb 2026

is this function required?

DD-LDT-815-1 03 Jul 2025

Done.

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

If the script is not passing enough parameters, we need to notify the user.
Use the

status   (tr     ("The WiFi info response error"));
LOG_DEBUG(QString("The WiFi info response length is not correct [%1 of %2]").arg(len).arg(eCount))

to notify user.

Please test my suggested code/s

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

this has been updated and screen adjusted

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

done

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

removed items and using existing arrows

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

removed items and using existing arrows

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

removed items and using existing arrows

LEAHI-BOOTLOADER-LDT-3259-1 27 Feb 2026

Why 2 conditions? Are there 2 ways to initiate an update?

And why isn't this check done in the CHECK_FOR_UPDATE_STATE?

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

removed items and using existing arrows

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

I cannot find the use case.
Please remove if not used.

LEAHI-BOOTLOADER-LDT-3259-1 27 Feb 2026

Where is this function defined?

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 08 Jul 2025

Same here:
http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-853-1CFR-69103

LEAHI-APPLICATION-LDT-853-1 08 Jul 2025

The two arrows are a little too separated. Can they get closer?

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Added

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove gradient

LEAHI-TD-FIRMWARE-LDT-3126-1 27 Feb 2026

Added

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

RESOLVED

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

remove

LEAHI-APPLICATION-LDT-853-1 10 Jul 2025

updated and removed

LEAHI-APPLICATION-LDT-853-1 09 Jul 2025

create a more general component for this