•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-16391-1 28 Nov 2023

Would dgCurrentActiveReservoir be a better name? I assume Temp refers to temperature (not temporary), but purpose is still not clear.

HD-DEN-14906-1 15 Mar 2023

Done

HD-DEN-14906-1 14 Mar 2023

I don't understand what the timer > 5 hours is doing here. Timer counter should never get bigger than 30 minutes (resets to zero after reprime completes), so would never get to 5 hours anyway.
I think we just do reprime if 30 min interval OR 5 minutes remaining in treatment. And once we do the reprime for 5 min before end of treatment, we need some way to not do it again (i.e. if we just say time remaining <= 5 minutes, we will keep doing reprimes over and over again for the last 5 minutes).

HD-DEN-14906-1 14 Mar 2023

Switching valves to dialyzer with DPo stopped initially will be a shock and temporarily send a lot of dialysate to the patient while DPo ramps up. So I think DPi should be hard stopped first and then start both DPi and DPo at fast purge rate together.

HD-DEN-16512-1 04 Dec 2023

Consider splitting this if and the setDialysisParams() function into two: 1) blood flow rate changed and 2) dialysate flow rate changed.

HD-DEN-14906-1 15 Mar 2023

Just wondering whether a reset function was needed for reprime. Looks like you've added one.
RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

I think it would make more sense to set DPi rate to zero, set re-prime in progress flag to FALSE, and set state to dialysate pumps off which will then handle the ramp down and transition to reprime state.

HD-DEN-14906-1 14 Mar 2023

Recommend removing this else if and just commanding pumps to zero when transitioning to reprime state.

TD-LEAH-838-2 21 Feb 2025

Done.

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 14 Mar 2023

Need to command dialysate pumps to zero flow rate so they start ramping down.

HD-DEN-14906-1 14 Mar 2023

If we get interrupted by an alarm, how will these vars get reset?

TD-LEAH-838-1 21 Feb 2025

Done.

HD-DEN-14906-1 15 Mar 2023

Done.

HD-DEN-14906-1 14 Mar 2023

Maybe state durations instead of function delays.

TD-LEAH-838-1 20 Feb 2025

May be add a check to validate the power level between 0 to 255.

DG-DEN-14763-1 15 Mar 2023

Done.

TD-LEAH-838-1 20 Feb 2025

#define the 1 and 0.

DG-DEN-14763-1 15 Mar 2023

Done.

DG-DEN-14763-1 15 Mar 2023

Done.

DG-DEN-14763-1 15 Mar 2023

Done.

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

fixed!

DG-DEN-14763-1 15 Mar 2023

Done.

DG-DEN-14763-1 15 Mar 2023

Revised the comment.

UI-DEN-17157-1 25 Feb 2025

same here

DG-DEN-14646-1 16 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

RESOLVED

HD-DEN-14888-1 16 Mar 2023

Fixed.

HD-DEN-14888-1 16 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14888-1 16 Mar 2023

Do we still need the TODO?

UI-DEN-14909-1 13 Mar 2023

Regarding our new design change requests all tick marks shall be round by default.

UI-DEN-14909-1 14 Mar 2023

RESOLVED

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Fixed. Thanks!

HD-DEN-14906-1 15 Mar 2023

Done.

LEAHI-APPLICATION-LDT-1616-1 18 Sep 2025

RESOLVED

HD-DEN-14906-1 15 Mar 2023

Need more info.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

RESOLVED

HD-DEN-14906-1 15 Mar 2023

Done.

HD-DEN-16512-1 27 Nov 2023

Remove blank line.

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 14 Mar 2023

I don't think we can just shift into reverse here. I think I had last SRS written in a way that we would go tack to the dialysate pumps off state to ramp down again before moving to reprime state.

HD-DEN-16391-1 27 Nov 2023

Any reason why these reservoir variables are not part of the DG_TDI_TEMP_COUNTER_T structure?

DG-DEN-14763-1 15 Mar 2023

tempBelowTargetStartTimeMS is not longer set in this state.

DG-DEN-14646-1 27 Feb 2023

extra CR/LF deleted; two statements on one line.

HD-DEN-16391-1 27 Nov 2023

Space after if.

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Fixed. Thanks!

HD-DEN-14888-1 16 Mar 2023

RESOLVED IN CODE WALKTHROUGH

HD-DEN-14888-1 16 Mar 2023

Please add these event types to your dialin CR.