•  

Comment Results

Review Name Created Custom Fields Content
HD-DEN-14689-1 10 Mar 2023

Isn't deleted statement correct?

DG-DEN-14646-1 14 Mar 2023

Yes.

UI-DEN-14838-1 14 Mar 2023

RESOLVED

UI-DEN-14838-1 14 Mar 2023

RESOLVED

UI-DEN-14909-1 14 Mar 2023

RESOLVED

UI-DEN-14909-1 13 Mar 2023

Why was this property added?

UI-DEN-14909-1 14 Mar 2023

RESOLVED

DG-DEN-14646-1 14 Mar 2023

RESOLVED IN CODE WALKTHROUGH.

DG-DEN-14646-1 14 Mar 2023

Corrected.

HD-DEN-14860-1 14 Mar 2023

Updated.

HD-DEN-14906-1 15 Mar 2023

Removed and replaced with a different approach (flag)

HD-DEN-14906-1 15 Mar 2023

This was done with a flag instead.

HD-DEN-14860-1 12 Mar 2023

Indent for reddability?

HD-DEN-14888-1 12 Mar 2023

Don't see timeReservoirInUF being used?

DG-DEN-14646-1 13 Mar 2023

Maybe we should put a bread crumb comment here to make it easier to find lines of code that need to be commented out when debugging (e.g. // comment this line for DEBUG).

DG-DEN-14646-1 13 Mar 2023

DEBUG bread crumb comment.

DG-DEN-14763-1 20 Mar 2023

This seems wrong.

DG-DEN-14763-1 21 Mar 2023

RESOLVED in CODE WALKTHROUGH.

DG-DEN-14646-1 13 Mar 2023

DEBUG bread crumb comment?

LEAHI-APPLICATION-LDT-1616-1 17 Sep 2025

reverted this back

DG-DEN-14763-1 16 Mar 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14763-1 16 Mar 2023

RESOLVED IN CODE WALKTHROUGH

DG-DEN-14763-1 14 Mar 2023

Function header.

UI-DEN-14909-1 13 Mar 2023

This may be a new concept for the project, but it's something that I've used and have seen used before in other QML projects.

This also guarantees that you are only loading the object when you need it when you use it with the Loader.

The Component itself, if you look at the Qt documentation, you will find "The component encapsulates the QML types within, as if they were defined in a separate QML file, and is not loaded until requested (in this case, by the two Loader objects)."

So, I am sure this is efficient.

HD-DEN-16391-1 27 Nov 2023

Done.

DG-DEN-14763-1 14 Mar 2023

Add concCap and diaCap to header.

HD-DEN-16391-1 27 Nov 2023

Done.

HD-DEN-14906-1 15 Mar 2023

Space before ")"

TD-LEAH-838-1 21 Feb 2025

Done.

HD-DEN-16512-1 28 Nov 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 15 Mar 2023

Done

HD-DEN-16391-1 27 Nov 2023

Space after if.
Also, consider refactoring this code by combining with if statement above.

HD-DEN-14906-1 15 Mar 2023

Created an init function that initializes variables and sets the pump flow rates to 0.

HD-DEN-14906-1 15 Mar 2023

RESOLVED in CODE WALKTHROUGH.

HD-DEN-14906-1 14 Mar 2023

I think the rest of these are durations, not intervals.

HD-DEN-14906-1 14 Mar 2023

Comment doesn't match const name.
This is essentially 5 hours. Why are we repriming after 5 hours?
We have a #define below that seems to be better suited for the reprime 5 minutes before end of treatment. So why do we need this const?

TD-LEAH-838-1 20 Feb 2025

Remove events message.

UI-DEN-17206-4 10 Feb 2025

Does this comment need to be updated since the x parameter was added back?

DG-DEN-14763-1 16 Mar 2023

RESOLVED IN CODE WALKTHROUGH

TD-LEAH-838-1 20 Feb 2025

Do we need explicit typecast to U32?

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

There is currently no FW implementation of an error counter override nor a MSG_ID defined.

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Refactor per f/w naming.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Rename variables per f/w naming.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Temperature sensor read counter value. And is there also an override for error counter?

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Rev count should be U32. please fix all below rev counts ( target and measured rev counts for d10 and d11)

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Leahi heaters states modified from denali, please update the states per DD firmware.

LEAHI-APPLICATION-LDT-627-1 30 Jun 2025

put a comment in the mode.
Please refactor the field for the model and update it wherever it has been used.
http://devapps.diality.us:8060/cru/#LEAHI-APPLICATION-LDT-627-1CFR-68162

RO-LDT-566-1 30 Jun 2025

fixed. thanks!