Comment Search

RESOLVED

• Add the eCount
• Check the size/count of the fields before use (before the if statement on line 559).

It is always best practice to add an eCount enum item at the end of any enum and verify the size of the array or list that uses the enum as an index; otherwise, you are very likely to encounter an index out of range error and cause the software to crash.

Please review the other enums you may have and apply the same.

updated

updated

Corrected.

Fixed.

fixed,
thanks for pointing that out.

I disagree. If we bind the value here to the "active" property, the value it takes is whatever "active" has when the component gets created.

Fixed. Thanks!

Fixed. Thanks!

Thanks for the feedback,
The comment refers to the x (non-capital), the new one that has been added is a new option with X (capital), therefore the comment is still valid.

RESOLVED

RESOLVED

To answer this and comment below:

above_high_safety_range = temp > 46
above_low_safety_range = temp > 42
above_target_temp = target + 4
below_target_temp = target - 4
below_low_safety_range = temp < 33

I did not see any specification regarding to separate or not to separate. Original functionality had separate triggers. Respective PRS's state OR between the two triggers.
I think it would be clear to for us in terms of debugging to see which alarm is triggered since on the low side, temp - 4 would be lower than 33, (31).

Wording may be unclear. Im up for suggestions to help clarify the alarm differences.

Done.

Remove blank line.

Comments for these target flows should explain why they're here (instead of just getting flow from flow module).

What is the point of subtracting 0.0?

Where did this go?

RESOLVED in CODE WALKTHROUGH.

RESOLVED IN CODE WALKTHROUGH.

This should be U32.

Fixed?

please remove an extra empty line which is not necessary.

Fixed.