•  

Comment Results

Review Name Created Custom Fields Content
LEAHI-DIALIN-LEAH-136-3 05 Feb 2025

Fixed. Thanks!

UI-DEN-16526-3 03 Nov 2023

Used your exact suggestion.
thanks,

LEAHI-APPLICATION-LDT-1616-1 18 Sep 2025

Thanks
RESOLVED.

UI-DEN-14866-1 03 Mar 2023

This is the default value of the heparinStopTime.
If you bind to the active of the dispensing switch nothing will happen, since the switch by default is active=false and if active is not changed, no signal, therefore no property change will happen, and the enable remains unchanged, as true.

UI-DEN-16526-3 03 Nov 2023

RESOLVED

LEAHI-DIALIN-LEAH-139-3 06 Feb 2025

Fixed. Thanks!

UI-DEN-14866-1 03 Mar 2023

RESOLVED

LEAHI-APPLICATION-LDT-783-1 19 Sep 2025

Added.

RO-LEAH-273-1 04 Mar 2025

RO (or FP), not DD.

RO-LEAH-273-1 04 Mar 2025

See comment above - is this function necessary?

DRY-DEMO-DEN-16481-3 15 Nov 2023

No changes in this branch follow up the story with the following link:

https://diality.atlassian.net/browse/DEN-16540

HD-DEN-16391-1 27 Nov 2023

Done.

HD-DEN-16391-1 27 Nov 2023

Done.

HD-DEN-16391-1 27 Nov 2023

Done.

HD-DEN-16512-1 27 Nov 2023

Done.

HD-DEN-16512-1 27 Nov 2023

Done.

HD-DEN-16391-1 20 Nov 2023

Extra blank line.

HD-DENBUG-326-1 22 Sep 2025

How is this if different than the else above? I don't think we need a separate if/else for not detected debounce - everything can be done in the if/else above.

TD-LEAH-838-1 21 Feb 2025

I would say we are required to explicitly typecast if any of the following are true:
1) compiler warning if you don't
2) byte count/mem size matters (e.g. message payload) and might not match desired size if you don't cast it

I don't think either is true in this case.

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

DG should be DD.

LEAHI-APPLICATION-LDT-1616-1 22 Sep 2025

updated to not show when on create Rx screen

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DD-FIRMWARE-LDT-2198-1 23 Sep 2025

Do you want to add a space for the baro pressure sensor from which we receive from the TD?

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

DG should be DD.

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

Not conductivity.

LEAHI-DIALIN-LEAH-139-3 11 Feb 2025

Not conductivity.

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-APPLICATION-LDT-1616-1 23 Sep 2025

I am using the *set from the VALUESET macro to sync the isActive of the 2 instances of the component

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 12 Feb 2025

Fixed. Thanks!

LEAHI-DIALIN-LEAH-139-3 10 Feb 2025

The naming convention to be followed in general ( as agreed upon with the system team and others): 1) PUMP should be D10_PUMP, D11_PUMP, D12_PUMP
2) VALV should be D3_VALV, D65_VALV ....

TD-LEAH-838-1 21 Feb 2025

Done.

TD-LEAH-838-1 20 Feb 2025

Do we need to rename LevelSensors to AirTrapLevelSensors to get right context?

DD-LEAH-224-1 24 Feb 2025

Done.

DD-LEAH-224-1 24 Feb 2025

Done.

UI-DEN-17157-1 25 Feb 2025

Done

UI-DEN-17157-1 25 Feb 2025

RESOLVED

DG-DEN-17234-1 27 Feb 2025

RESOLVED in CODE WALKTHROUGH.

RO-LDT-566-1 30 Jun 2025

renamed to TemperatureSensors

RO-LEAH-273-1 05 Mar 2025

Fixed. Thanks!

LEAHI-APPLICATION-LDT-627-1 29 Jun 2025

Did you also add the TDOpMode in diagnostics?

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

fixed!

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

fixed

LEAHI-APPLICATION-LDT-627-1 01 Jul 2025

fixed!

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

updated

LEAHI-APPLICATION-LDT-1021-1 01 Jul 2025

fixed